From 480b1389e3060d224c0b18ff87b8d5cdf67e04cd Mon Sep 17 00:00:00 2001 From: Abir Abbas Date: Sat, 14 Nov 2026 10:42:58 -0500 Subject: [PATCH 1/2] tui3: a shell line from Home is recorded as a shell line in tests again #2287 added a SubmitBash method to the shared switchAgent test fake. It shadowed fakeAgent.SubmitBash, which records the line in bashSent, so TestUserBashHomeRunsInTheSelectedProject saw the command arrive as a plain send and failed on dev. Removing it restores the shared method, which calls the same Submit and also records the line. Co-Authored-By: Claude Opus 5.5 --- internal/tui3/idle_r9_send_test.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/internal/tui3/idle_r9_send_test.go b/internal/tui3/idle_r9_send_test.go index dc9d69ca3e..43c9ea6318 100644 --- a/internal/tui3/idle_r9_send_test.go +++ b/internal/tui3/idle_r9_send_test.go @@ -332,10 +332,6 @@ func (a *p9xBashAgent) SubmitBash(_ context.Context, line string) (<-chan sessio return ch, nil } -func (a *switchAgent) SubmitBash(ctx context.Context, line string) (<-chan session.Event, error) { - return a.Submit(ctx, line) -} - func TestIdleOpen_P9X1_BashCommandRunsOwnershipCheckAndKeepsWords(t *testing.T) { t.Run("offline refusal keeps bash line in box and prints one line", func(t *testing.T) { a, old, source := r8OwnLiveWindow(t, false) From 894a330fd32deb05490b4edfa514bea1148b476f Mon Sep 17 00:00:00 2001 From: Abir Abbas Date: Sat, 14 Nov 2026 10:43:23 -0500 Subject: [PATCH 2/2] changes: entry for #2644 Co-Authored-By: Claude Opus 5.5 --- docs/changes/unreleased/2644-home-bash-test-fake.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 docs/changes/unreleased/2644-home-bash-test-fake.md diff --git a/docs/changes/unreleased/2644-home-bash-test-fake.md b/docs/changes/unreleased/2644-home-bash-test-fake.md new file mode 100644 index 0000000000..72ecc31ec3 --- /dev/null +++ b/docs/changes/unreleased/2644-home-bash-test-fake.md @@ -0,0 +1,7 @@ +--- +kind: internal +title: The tui3 test fake records a shell line from Home again, so the dev gate is green after #2287 +pr: 2644 +surface: [chat] +invalidates: [] +---