diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ba70769fa3..51c8b9862d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -386,7 +386,9 @@ jobs: # next language the recognizer has, or says which language to add and where. The page's # language and its names for languages are the engine's own. And the sidebar's edge, dragged in a # window zoomed in, narrowing the sidebar, which never takes more than two-fifths of the window. - # In the image, as above: WebKit's + # And the terms on OpenBot Cloud: the gate holding a person at them from anywhere until they tick + # the box and agree, asking again when they change, and never shown where there are none, in the + # engine the Mac window draws with too. In the image, as above: WebKit's # system packages are about 94 MB, which took nine minutes from the mirror on a slow day. app-browser-webkit: name: app (real browser, WebKit) @@ -410,7 +412,7 @@ jobs: --volume "$(command -v bun):/usr/local/bin/bun:ro" \ --env OPENBOT_APP_BROWSER=1 --env OPENBOT_APP_ENGINES=chromium,webkit \ "$PLAYWRIGHT_IMAGE" \ - bun test app/tests/composer-dictation-language.test.tsx app/tests/sidebar-zoom-drag.test.tsx + bun test app/tests/composer-dictation-language.test.tsx app/tests/sidebar-zoom-drag.test.tsx app/tests/service-terms.test.tsx # The desktop setup window's, for the same reason as the list above: the AI step's form holding # still while the install behind it comes and goes. It bundles the window from the desktop's own diff --git a/app/src/components/onboarding/onboarding-frame.tsx b/app/src/components/onboarding/onboarding-frame.tsx index 07d5d6558c..11969d7a1c 100644 --- a/app/src/components/onboarding/onboarding-frame.tsx +++ b/app/src/components/onboarding/onboarding-frame.tsx @@ -178,8 +178,12 @@ export function OnboardingFrame({ * On a phone, a step taller than the screen scrolls under the buttons rather than being cut * at them: the fade above says there is more. On a desktop they sit at the bottom of the * pane, under the row that takes up the space between them and the sentence. + * + * The 32px above the buttons on a phone is the fade's own height. Scrolled to the end there + * is nothing more, so the step's last line (Welcome's carousel dots) stops above the fade + * rather than half hidden in it. */} -