From b27295654075af8fde96223ee6ed8147ccad3c99 Mon Sep 17 00:00:00 2001 From: franckgaga Date: Fri, 20 Nov 2026 12:43:30 -0500 Subject: [PATCH 1/5] added: `ExplicitMPC` now support `ReverseDiff.jl` --- src/controller/construct.jl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/controller/construct.jl b/src/controller/construct.jl index d010cfe41..2a4481543 100644 --- a/src/controller/construct.jl +++ b/src/controller/construct.jl @@ -97,7 +97,9 @@ function ControllerWeights( model::SimModel{NT}, Hp, Hc, M_Hp, N_Hc, L_Hp, Cwt=Inf, Ewt=0 ) where {NT<:Real} validate_weights(model, Hp, Hc, M_Hp, N_Hc, L_Hp, Cwt, Ewt) - M_Hp, N_Hc, L_Hp = NT.(M_Hp), NT.(N_Hc), NT.(L_Hp) + M_Hp = eltype(M_Hp) == NT ? M_Hp : NT.(M_Hp) + N_Hc = eltype(N_Hc) == NT ? N_Hc : NT.(N_Hc) + L_Hp = eltype(L_Hp) == NT ? L_Hp : NT.(L_Hp) return ControllerWeights{NT}(M_Hp, N_Hc, L_Hp, Cwt, Ewt) end From 68eb317a032440a79078806a84f5532381cc9265 Mon Sep 17 00:00:00 2001 From: franckgaga Date: Fri, 20 Nov 2026 12:43:48 -0500 Subject: [PATCH 2/5] bump --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index d58d884e0..8a950c0c8 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "ModelPredictiveControl" uuid = "61f9bdb8-6ae4-484a-811f-bbf86720c31c" -version = "2.16.5" +version = "2.16.6" authors = ["Francis Gagnon"] [deps] From d9f1359f46ef59e24ff5bb3ad185aa8922886637 Mon Sep 17 00:00:00 2001 From: franckgaga Date: Fri, 20 Nov 2026 14:14:26 -0500 Subject: [PATCH 3/5] debug: avoid duplicate `Hermitian` wrappers --- src/controller/construct.jl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/controller/construct.jl b/src/controller/construct.jl index 2a4481543..1f0f6b654 100644 --- a/src/controller/construct.jl +++ b/src/controller/construct.jl @@ -85,6 +85,10 @@ struct ControllerWeights{ iszero_Ñ_Hc = [iszero(Ñ_Hc)] iszero_L_Hp = [iszero(L_Hp)] iszero_E = iszero(E) + @show typeof(M_Hp) + @show MW + @show Hermitian{NT,MW} + @show Hermitian{NT,NW} return new{NT,MW,NW,LW}( M_Hp, Ñ_Hc, L_Hp, E, iszero_M_Hp, iszero_Ñ_Hc, iszero_L_Hp, iszero_E, isinf_C @@ -100,6 +104,10 @@ function ControllerWeights( M_Hp = eltype(M_Hp) == NT ? M_Hp : NT.(M_Hp) N_Hc = eltype(N_Hc) == NT ? N_Hc : NT.(N_Hc) L_Hp = eltype(L_Hp) == NT ? L_Hp : NT.(L_Hp) + # Hermitian wrappers are added in the inner constructor, remove it to avoid duplicates: + M_Hp = M_Hp isa Hermitian ? parent(M_Hp) : M_Hp + N_Hc = N_Hc isa Hermitian ? parent(N_Hc) : N_Hc + L_Hp = L_Hp isa Hermitian ? parent(L_Hp) : L_Hp return ControllerWeights{NT}(M_Hp, N_Hc, L_Hp, Cwt, Ewt) end From 1f438ed134515b3c3717c8aee8fc14258011badb Mon Sep 17 00:00:00 2001 From: franckgaga Date: Fri, 20 Nov 2026 14:20:02 -0500 Subject: [PATCH 4/5] added: same improvements in `KalmanCovariances` --- src/estimator/construct.jl | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/estimator/construct.jl b/src/estimator/construct.jl index 7091ccb8f..2f089a3f7 100644 --- a/src/estimator/construct.jl +++ b/src/estimator/construct.jl @@ -141,8 +141,15 @@ function KalmanCovariances( model::SimModel{NT}, i_ym, nint_u, nint_ym, Q̂, R̂, P̂_0=nothing, He=1 ) where {NT<:Real} validate_kfcov(model, i_ym, nint_u, nint_ym, Q̂, R̂, P̂_0) - Q̂, R̂ = NT.(Q̂), NT.(R̂) - !isnothing(P̂_0) && (P̂_0 = NT.(P̂_0)) + Q̂ = eltype(Q̂) == NT ? Q̂ : NT.(Q̂) + R̂ = eltype(R̂) == NT ? R̂ : NT.(R̂) + # Hermitian wrappers are added in the inner constructor, remove it to avoid duplicates: + Q̂ = Q̂ isa Hermitian ? parent(Q̂) : Q̂ + R̂ = R̂ isa Hermitian ? parent(R̂) : R̂ + if !isnothing(P̂_0) + P̂_0 = eltype(P̂_0) == NT ? P̂_0 : NT.(P̂_0) + P̂_0 = P̂_0 isa Hermitian ? parent(P̂_0) : P̂_0 + end return KalmanCovariances{NT}(Q̂, R̂, P̂_0, He) end From e4cbef300d5c29c3c8dd3c88a4a1090f374ef0fe Mon Sep 17 00:00:00 2001 From: franckgaga Date: Fri, 20 Nov 2026 14:21:41 -0500 Subject: [PATCH 5/5] removed: useless prints --- src/controller/construct.jl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/controller/construct.jl b/src/controller/construct.jl index 1f0f6b654..3b5cdc278 100644 --- a/src/controller/construct.jl +++ b/src/controller/construct.jl @@ -85,10 +85,6 @@ struct ControllerWeights{ iszero_Ñ_Hc = [iszero(Ñ_Hc)] iszero_L_Hp = [iszero(L_Hp)] iszero_E = iszero(E) - @show typeof(M_Hp) - @show MW - @show Hermitian{NT,MW} - @show Hermitian{NT,NW} return new{NT,MW,NW,LW}( M_Hp, Ñ_Hc, L_Hp, E, iszero_M_Hp, iszero_Ñ_Hc, iszero_L_Hp, iszero_E, isinf_C