From 0996669befd53a5e66ac5d23cdc2f38d39626b07 Mon Sep 17 00:00:00 2001 From: Svilen Markov <7613769+svilenmarkov@users.noreply.github.com> Date: Sun, 8 Nov 2026 18:45:02 +0000 Subject: [PATCH 1/2] Use completion.requireFunction for auto-require syntax and insert position --- script/core/command/autoRequire.lua | 3 ++- test/command/auto-require.lua | 13 +++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/script/core/command/autoRequire.lua b/script/core/command/autoRequire.lua index afdfb238c..ff8edf0ec 100644 --- a/script/core/command/autoRequire.lua +++ b/script/core/command/autoRequire.lua @@ -24,6 +24,7 @@ local function findInsertRow(uri) if not state or not text then return end + local requireName = config.get(uri, "Lua.completion.requireFunction") local lines = state.lines local fmt = { pair = false, @@ -37,7 +38,7 @@ local function findInsertRow(uri) end local ln = lines[i] local lnText = text:match('[^\r\n]*', ln) - if not lnText:find('require', 1, true) then + if not lnText:find(requireName, 1, true) then if row then break end diff --git a/test/command/auto-require.lua b/test/command/auto-require.lua index f17968d80..5932a1455 100644 --- a/test/command/auto-require.lua +++ b/test/command/auto-require.lua @@ -2,6 +2,7 @@ local util = require 'utility' local files = require 'files' local autoRequire = require 'core.command.autoRequire' local client = require 'client' +local config = require 'config' local findInsertRow = util.getUpvalue(autoRequire, 'findInsertRow') local applyAutoRequire = util.getUpvalue(autoRequire, 'applyAutoRequire') @@ -92,4 +93,16 @@ end text = 'local test = require "test"\n' } +local originRequireFunction = config.get(nil, 'Lua.completion.requireFunction') +config.set(nil, 'Lua.completion.requireFunction', 'import') +TEST [[ +local modulea = import("modulea") +local moduleb = import("moduleb") +]] 'modulec' { + start = 20000, + finish = 20000, + text = 'local modulec = import("modulec")\n' +} +config.set(nil, 'Lua.completion.requireFunction', originRequireFunction) + client.editText = originEditText From 633d8697a9d5d3478c5199e83a322f969f59c7c0 Mon Sep 17 00:00:00 2001 From: Svilen Markov <7613769+svilenmarkov@users.noreply.github.com> Date: Sun, 8 Nov 2026 19:03:07 +0000 Subject: [PATCH 2/2] Update changelog --- changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.md b/changelog.md index daefdb5ae..2c0261f72 100644 --- a/changelog.md +++ b/changelog.md @@ -2,6 +2,7 @@ ## Unreleased +* `FIX` Auto-require now detects existing imports using `Lua.completion.requireFunction` (e.g. `import`) instead of `require`, so new imports use the preferred syntax and get inserted after existing ones ## 3.19.2 `2026-10-13`