From f2292860ed9e277daf0c1d851e0fd160d7081fbb Mon Sep 17 00:00:00 2001 From: ARAYN7011 <88572149+ARAYN7011@users.noreply.github.com> Date: Wed, 18 Nov 2026 11:22:58 +0530 Subject: [PATCH] Serialize boolean fenced code attributes without codehilite Boolean options (e.g. linenums) set via attr_list were passed to the escape helper as bool objects, raising TypeError when codehilite is not enabled. Serialize them the way the serializer does. Fixes #1713. Co-Authored-By: Claude Sonnet 5.5 --- docs/changelog.md | 3 ++ markdown/extensions/fenced_code.py | 17 ++++++++- .../extensions/test_fenced_code.py | 37 +++++++++++++++++++ 3 files changed, 55 insertions(+), 2 deletions(-) diff --git a/docs/changelog.md b/docs/changelog.md index 828d283cb..914cca293 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -16,6 +16,9 @@ See the [Contributing Guide](contributing.md) for details. ### Fixed +* The `fenced_code` extension no longer raises `TypeError` for boolean options (e.g. + `linenums=true`) set with `attr_list` when `codehilite` is not enabled. The values + are now serialized like any other attribute (#1713). * The `toc` extension no longer raises `TypeError` for a heading whose `data-toc-label` attribute is present but valueless, as the `attr_list` extension's bare-attribute syntax (`{: data-toc-label }`) writes it: like a diff --git a/markdown/extensions/fenced_code.py b/markdown/extensions/fenced_code.py index 944b4e42b..9ff1b28d7 100644 --- a/markdown/extensions/fenced_code.py +++ b/markdown/extensions/fenced_code.py @@ -27,7 +27,7 @@ from .codehilite import CodeHilite, CodeHiliteExtension, parse_hl_lines from .attr_list import get_attrs_and_remainder, sanitize_name, AttrListExtension from ..util import parseBoolValue -from ..serializers import _escape_attrib_html +from ..serializers import _escape_attrib_html, BOOLEAN_ATTRIBUTES import re from typing import TYPE_CHECKING, Any, Iterable @@ -160,7 +160,7 @@ def run(self, lines: list[str]) -> list[str]: # pairs were defined on the code block, and the `use_pygments` key was not set to `True`. The # `use_pygments` key could be either set to `False` or not defined. It is omitted from output. kv_pairs = ''.join( - f' {sanitize_name(k)}="{_escape_attrib_html(v)}"' + self._format_attr(k, v) for k, v in config.items() if k != 'use_pygments' ) code = self._escape(m.group('code')) @@ -175,6 +175,19 @@ def run(self, lines: list[str]) -> list[str]: pieces.append(text[last:]) return "".join(pieces).split("\n") + def _format_attr(self, key: str, value: Any) -> str: + """ Serialize a key/value pair for the `code` element as the serializer would. """ + key = sanitize_name(key) + if value is None: + return f' {key}' + if value is True: + if self.md.output_format == 'html' and key in BOOLEAN_ATTRIBUTES['html']: + return f' {key}' + return f' {key}="{key}"' + if value is False: + return '' + return f' {key}="{_escape_attrib_html(value)}"' + def handle_attrs( self, attrs: Iterable[tuple[str, str | None]] ) -> tuple[str, list[str], dict[str, Any]]: diff --git a/tests/test_syntax/extensions/test_fenced_code.py b/tests/test_syntax/extensions/test_fenced_code.py index 43a691591..095f8af54 100644 --- a/tests/test_syntax/extensions/test_fenced_code.py +++ b/tests/test_syntax/extensions/test_fenced_code.py @@ -455,6 +455,43 @@ def testFencedCodeMismatchedCurlyInAttrs(self): extensions=['fenced_code', 'attr_list'] ) + def testFencedCodeBooleanAttrsWithoutCodehilite(self): + # Boolean options are serialized like `attr_list` attributes when `codehilite` is not enabled (#1713). + self.assertMarkdownRenders( + self.dedent( + ''' + ```{.py linenums=true} + # Some python code + ``` + ''' + ), + self.dedent( + ''' +
# Some python code
+                
+ ''' + ), + extensions=['fenced_code', 'attr_list'] + ) + + def testFencedCodeFalseBooleanAttrWithoutCodehilite(self): + self.assertMarkdownRenders( + self.dedent( + ''' + ```{.py linenums=false} + # Some python code + ``` + ''' + ), + self.dedent( + ''' +
# Some python code
+                
+ ''' + ), + extensions=['fenced_code', 'attr_list'] + ) + def testMultipleFencedBlocks(self): self.assertMarkdownRenders( self.dedent(