From f1b50493d8ab86abca8c197f8e3c43ea286c1482 Mon Sep 17 00:00:00 2001 From: tannevaled Date: Sat, 31 Oct 2026 23:44:16 +0100 Subject: [PATCH 1/2] =?UTF-8?q?consume=20the=20kit's=20icons:=20delete=20t?= =?UTF-8?q?hree=20local=20files,=20bump=20v0.14.0=20=E2=86=92=20v0.17.0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This repository carried exactly three files under `layouts/partials/` beyond what the kit provides, and all three were duplication: ``` layouts/partials/icons/graph.html Octicons "graph", verbatim layouts/partials/icons/rocket.html Octicons "rocket", verbatim layouts/partials/icons/OCTICONS-LICENSE byte-identical to the kit's ``` They were **additions, not overrides** — nothing was being shadowed — but they were not local in any meaningful sense: both icons come from the same Octicons release the kit's own name (`@primer/octicons-react@19.40.0`), carry the same `currentColor`/`aria-hidden` convention as `icons/github.html`, and contain nothing specific to this project. A graph and a rocket are what any landing's benchmarks and quickstart buttons want. go-fleettools/landingkit#27 moved them into the kit (v0.17.0). This consumes them. ## Proven by the only test that settles it: the built site is byte-identical ```console $ hugo --destination …/baseline # on main, with the local copies $ # delete the three files, bump the kit $ hugo --destination …/after $ diff -r …/baseline …/after $ echo $? 0 ``` **Zero lines of difference.** The icons now resolve from the module and render the same bytes, and three minor versions of kit changes (v0.14.0 → v0.17.0, a bump that was overdue on its own) introduce no visible change to this site either. If a partial had gone missing, hugo would have failed rather than rendered nothing — so this also proves the kit really supplies them. `landingkit links` on the rebuilt site: every URL 200. ## Why copies were the problem rather than the files Every landing that wants a rocket copies one, and from then on there are N rockets: the next accessibility or sizing fix to `icons/github.html` reaches the kit's five and none of the copies. This kit exists because hand-copied `styles.html` and `theme-toggle.html` had already drifted between landings — `hugo.toml` says so at the `[module]` block. Co-Authored-By: Claude Opus 5 --- layouts/partials/icons/OCTICONS-LICENSE | 21 --------------------- layouts/partials/icons/graph.html | 5 ----- layouts/partials/icons/rocket.html | 5 ----- 3 files changed, 31 deletions(-) delete mode 100644 layouts/partials/icons/OCTICONS-LICENSE delete mode 100644 layouts/partials/icons/graph.html delete mode 100644 layouts/partials/icons/rocket.html diff --git a/layouts/partials/icons/OCTICONS-LICENSE b/layouts/partials/icons/OCTICONS-LICENSE deleted file mode 100644 index aa1fa80..0000000 --- a/layouts/partials/icons/OCTICONS-LICENSE +++ /dev/null @@ -1,21 +0,0 @@ -MIT License - -Copyright (c) 2026 GitHub Inc. - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. diff --git a/layouts/partials/icons/graph.html b/layouts/partials/icons/graph.html deleted file mode 100644 index ed54531..0000000 --- a/layouts/partials/icons/graph.html +++ /dev/null @@ -1,5 +0,0 @@ -{{- /* Octicons "graph" (16 px), primer/octicons @primer/octicons-react@19.40.0, copied verbatim, MIT, - (c) GitHub Inc.: the licence is OCTICONS-LICENSE beside this file. - currentColor follows the button in light and dark; aria-hidden, since - the button's text already says where it leads. */ -}} - \ No newline at end of file diff --git a/layouts/partials/icons/rocket.html b/layouts/partials/icons/rocket.html deleted file mode 100644 index b4afed6..0000000 --- a/layouts/partials/icons/rocket.html +++ /dev/null @@ -1,5 +0,0 @@ -{{- /* Octicons "rocket" (16 px), primer/octicons @primer/octicons-react@19.40.0, copied verbatim, MIT, - (c) GitHub Inc.: the licence is OCTICONS-LICENSE beside this file. - currentColor follows the button in light and dark; aria-hidden, since - the button's text already says where it leads. */ -}} - \ No newline at end of file From eba9545df7324ea2e03449732a3cd95c5b3afdb5 Mon Sep 17 00:00:00 2001 From: tannevaled Date: Sat, 31 Oct 2026 23:45:28 +0100 Subject: [PATCH 2/2] go.mod: the kit bump the previous commit's message promised MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The commit before this one deletes the three local icon files and says it bumps the kit. It did not: `go.mod` and `go.sum` were modified in the working tree and **never staged**, so that commit alone deletes `icons/graph.html` and `icons/rocket.html` while still pinning landingkit v0.14.0, which does not provide them — hugo would fail on a missing partial. This commit carries the bump (v0.14.0 → v0.17.0). The two belong together and are only separate because amending a pushed commit rewrites history, which is not worth it for a branch whose pull request is still to open. ## ⛔ Why I did not notice before pushing The staging step was written as git add -A go.mod go.sum layouts/partials > /dev/null 2>&1 Two mistakes in one line. `-A` with several pathspecs did not stage the two module files here — plain `git add go.mod go.sum` does — and the output **and exit status went to /dev/null**, so a step that half-failed looked exactly like one that worked. The commit's own summary said "3 files changed", which is the number that gave it away on a second reading. The measurement in the previous commit's message is still true and was taken with both changes present in the working tree: `diff -r` over the two builds is byte-identical. It is this repository's recorded history that was wrong for one commit, not the result. Co-Authored-By: Claude Opus 5 --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index c9aa8a0..ca1f34d 100644 --- a/go.mod +++ b/go.mod @@ -2,4 +2,4 @@ module github.com/go-embedded-ruby/go-embedded-ruby.github.io go 1.27.3 -require github.com/go-fleettools/landingkit v0.14.0 +require github.com/go-fleettools/landingkit v0.17.0 diff --git a/go.sum b/go.sum index 12c6186..4cf59ea 100644 --- a/go.sum +++ b/go.sum @@ -1,2 +1,4 @@ github.com/go-fleettools/landingkit v0.14.0 h1:POih8vUJE2UHUUjDfsD90z+n4QWHz0OttGt1TP+fmnw= github.com/go-fleettools/landingkit v0.14.0/go.mod h1:gBpbziqFcmcjtNknPjy5+AAzGZ5L+pPr9mIJZHpDlZc= +github.com/go-fleettools/landingkit v0.17.0 h1:ai3LHx3sREMm7rxWgd0iXZPj8rAZo29F9bQxcOt3MrQ= +github.com/go-fleettools/landingkit v0.17.0/go.mod h1:gBpbziqFcmcjtNknPjy5+AAzGZ5L+pPr9mIJZHpDlZc=