From c6524d2fd26ae7622120407e9bec288e9d54ae15 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Mon, 16 Nov 2026 17:50:34 -0800 Subject: [PATCH] Verify preview removal after Azure delete errors Azure can accept a preview deletion and then return NotFound after the environment has been removed. Verify removal before reporting failure so successful cleanup does not leave a failed workflow run. --- .github/workflows/close-preview.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/close-preview.yml b/.github/workflows/close-preview.yml index a1db6432c5f7..c99c996903f8 100644 --- a/.github/workflows/close-preview.yml +++ b/.github/workflows/close-preview.yml @@ -58,7 +58,9 @@ jobs: # Avoid Azure CLI's subscription-scoped long-running-operation polling. resource_id="/subscriptions/{subscriptionId}/resourceGroups/$AZURE_RESOURCE_GROUP" resource_id+="/providers/Microsoft.Web/staticSites/$AZURE_STATIC_WEB_APP_NAME" - az rest --method delete --url "$resource_id/builds/$PR_NUMBER?api-version=2024-11-01" + if ! az rest --method delete --url "$resource_id/builds/$PR_NUMBER?api-version=2024-11-01"; then + echo "::warning::Delete returned an error; checking whether preview $PR_NUMBER was removed" + fi for _ in {1..30}; do environment="$(get_preview_environment)"