From 2c8d8e7d7fa6986bc16c4dbd8c3f8789075d48bf Mon Sep 17 00:00:00 2001 From: Bill Schnurr Date: Thu, 5 Nov 2026 13:51:28 -0700 Subject: [PATCH 1/2] Use shared localization tooling with English fallback Pin submission and release imports to the same reviewed shared revision. Untranslated handbacks no longer block packaging; required locale tables and structural checks remain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/localization.yml | 2 +- README.md | 2 +- build/azure-devdiv-pipeline.pre-release.yml | 2 +- build/azure-devdiv-pipeline.stable.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/localization.yml b/.github/workflows/localization.yml index 47bbfa92..8e302938 100644 --- a/.github/workflows/localization.yml +++ b/.github/workflows/localization.yml @@ -24,7 +24,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 20 steps: - - uses: microsoft/vscode-common-python-lsp/.github/actions/localization@d1877b84bb10ff7caa6bd12ab4e75498ba760790 + - uses: microsoft/vscode-common-python-lsp/.github/actions/localization@6b4a3573e7e7a9fe1e468e129544432278aec2d6 with: app-id: ${{ vars.PYTHON_LOCALIZATION_APP_ID }} private-key: ${{ secrets.PYTHON_LOCALIZATION_PRIVATE_KEY }} diff --git a/README.md b/README.md index b2d524cb..837216aa 100644 --- a/README.md +++ b/README.md @@ -143,4 +143,4 @@ Configure the `PYTHON_LOCALIZATION_APP_ID` Actions variable and `PYTHON_LOCALIZA Keep English `package.nls.json` tracked. Root `package.nls..json` and `l10n/` runtime files are generated, git-ignored release outputs. VSCE must include generated locale files despite Git ignores. Local builds are English-only unless translations are imported explicitly (debugger pre-built assets remain available, but the release import runs after their overlay and is authoritative). -Translation is asynchronous. All 14 supported locales must be present, and every required real-language table must contain translation evidence. Individual untranslated strings are allowed. Missing, incomplete, or wholly untranslated handbacks fail before packaging, without falling back to stale translations. Do not publish while onboarding or real translated output is pending. +Translation is asynchronous. Nonempty manifest and runtime tables must be present for all 14 supported locales. Untranslated strings, including wholly untranslated tables, are allowed; users see English until translations arrive. Missing, empty, malformed, or incomplete handbacks still fail before packaging, without falling back to stale translations. diff --git a/build/azure-devdiv-pipeline.pre-release.yml b/build/azure-devdiv-pipeline.pre-release.yml index 8a211c0f..dd616eb5 100644 --- a/build/azure-devdiv-pipeline.pre-release.yml +++ b/build/azure-devdiv-pipeline.pre-release.yml @@ -25,7 +25,7 @@ resources: - repository: localizationTools type: github name: microsoft/vscode-common-python-lsp - ref: d1877b84bb10ff7caa6bd12ab4e75498ba760790 + ref: 6b4a3573e7e7a9fe1e468e129544432278aec2d6 endpoint: Github-Pylance variables: - name: TeamName diff --git a/build/azure-devdiv-pipeline.stable.yml b/build/azure-devdiv-pipeline.stable.yml index d0ff387d..f2b30c5c 100644 --- a/build/azure-devdiv-pipeline.stable.yml +++ b/build/azure-devdiv-pipeline.stable.yml @@ -20,7 +20,7 @@ resources: - repository: localizationTools type: github name: microsoft/vscode-common-python-lsp - ref: d1877b84bb10ff7caa6bd12ab4e75498ba760790 + ref: 6b4a3573e7e7a9fe1e468e129544432278aec2d6 endpoint: Github-Pylance variables: - name: TeamName From 53585bc5fc37393f1300b3b1bab23f14e29b47f8 Mon Sep 17 00:00:00 2001 From: Bill Schnurr Date: Mon, 9 Nov 2026 15:26:11 -0700 Subject: [PATCH 2/2] Use GitHub Pylance engineering pipeline templates Switch both release resources to microsoft/pylance-eng through Github-Pylance while preserving release settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- README.md | 2 +- build/azure-devdiv-pipeline.pre-release.yml | 5 +++-- build/azure-devdiv-pipeline.stable.yml | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 837216aa..040a9b6f 100644 --- a/README.md +++ b/README.md @@ -139,7 +139,7 @@ The **Localization** GitHub workflow submits English strings using the [shared c Both paths use `microsoft/vscode-python-extensions-loc`, branch **`dev`**, with canonical extension ID **`ms-python.debugpy`**. English XLF is stored in `src/en/ms-python.debugpy` and handbacks in `out/ms-python.debugpy`. The action and Azure tooling checkout are pinned to the same reviewed revision. -Configure the `PYTHON_LOCALIZATION_APP_ID` Actions variable and `PYTHON_LOCALIZATION_PRIVATE_KEY` secret here, or grant access to organization-level credentials. The app needs Contents write access only to the localization drop; the caller's repository token stays read-only. The shared action uses the Microsoft npm proxy and pinned localization CLI. Authorize the literal `Github-Pylance` service connection for both Azure repository resources and release pipelines. +Configure the `PYTHON_LOCALIZATION_APP_ID` Actions variable and `PYTHON_LOCALIZATION_PRIVATE_KEY` secret here, or grant access to organization-level credentials. The app needs Contents write access only to the localization drop; the caller's repository token stays read-only. The shared action uses the Microsoft npm proxy and pinned localization CLI. Authorize the literal `Github-Pylance` service connection for the [pipeline templates](https://github.com/microsoft/pylance-eng), translation, and shared-tooling repository resources in both release pipelines. Keep English `package.nls.json` tracked. Root `package.nls..json` and `l10n/` runtime files are generated, git-ignored release outputs. VSCE must include generated locale files despite Git ignores. Local builds are English-only unless translations are imported explicitly (debugger pre-built assets remain available, but the release import runs after their overlay and is authoritative). diff --git a/build/azure-devdiv-pipeline.pre-release.yml b/build/azure-devdiv-pipeline.pre-release.yml index dd616eb5..03d05b1a 100644 --- a/build/azure-devdiv-pipeline.pre-release.yml +++ b/build/azure-devdiv-pipeline.pre-release.yml @@ -13,9 +13,10 @@ schedules: resources: repositories: - repository: templates - type: git - name: DevDiv/Pylance-Eng + type: github + name: microsoft/pylance-eng ref: refs/heads/main + endpoint: Github-Pylance - repository: translations type: github name: microsoft/vscode-python-extensions-loc diff --git a/build/azure-devdiv-pipeline.stable.yml b/build/azure-devdiv-pipeline.stable.yml index f2b30c5c..c3c75af3 100644 --- a/build/azure-devdiv-pipeline.stable.yml +++ b/build/azure-devdiv-pipeline.stable.yml @@ -8,9 +8,10 @@ pr: none resources: repositories: - repository: templates - type: git - name: DevDiv/Pylance-Eng + type: github + name: microsoft/pylance-eng ref: refs/heads/main + endpoint: Github-Pylance - repository: translations type: github name: microsoft/vscode-python-extensions-loc