From 85e515fbf3e70f4e2cc569f2d0b53ed54352dd21 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 6 Nov 2026 18:27:49 +0100 Subject: [PATCH] fix(v8): keep llvm-libc src/string in V8 updates V8 now sets LIBC_MATH_NO_EXCEPT, but the vendored llvm-libc no longer uses system fenv.h. On MacOS this ends up requiring src/string/memory_utils/inline_memcpy.h, so we need to check them in. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8705136 Refs: https://redirect.github.com/llvm/llvm-project/pull/224384 --- lib/update-v8/constants.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/update-v8/constants.js b/lib/update-v8/constants.js index 408423d3d..6169921bc 100644 --- a/lib/update-v8/constants.js +++ b/lib/update-v8/constants.js @@ -53,7 +53,8 @@ const llvmLibcIgnore = `/third_party/llvm-libc/src/* !/third_party/llvm-libc/src/shared !/third_party/llvm-libc/src/src /third_party/llvm-libc/src/src/* -!/third_party/llvm-libc/src/src/__support`; +!/third_party/llvm-libc/src/src/__support +!/third_party/llvm-libc/src/src/string`; export const v8Deps = [ {