From 9f35f7d7600840f3e3aebdda7069d2f96e316fb7 Mon Sep 17 00:00:00 2001 From: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com> Date: Wed, 4 Nov 2026 06:26:34 +0000 Subject: [PATCH] fix: preserve Instant precision when cloning a Value Value.clone() rebuilt Instant values with Instant.ofEpochMilli, which drops sub-millisecond precision. ImmutableStructure and ImmutableContext clone values on construction and on every read, so getValue() returned a different instant than the one stored. Instant is immutable, so the original instance is reused instead. Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com> --- src/main/java/dev/openfeature/sdk/Value.java | 4 ++-- .../dev/openfeature/sdk/ImmutableStructureTest.java | 13 +++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/main/java/dev/openfeature/sdk/Value.java b/src/main/java/dev/openfeature/sdk/Value.java index c13094d98..b9d70c170 100644 --- a/src/main/java/dev/openfeature/sdk/Value.java +++ b/src/main/java/dev/openfeature/sdk/Value.java @@ -295,8 +295,8 @@ protected Value clone() { return new Value(new ImmutableStructure(this.asStructure().asUnmodifiableMap())); } if (this.isInstant()) { - Instant copy = Instant.ofEpochMilli(this.asInstant().toEpochMilli()); - return new Value(copy); + // Instant is immutable, so the same instance is safe to share and keeps its full precision. + return new Value(this.asInstant()); } return new Value(this.asObject()); } diff --git a/src/test/java/dev/openfeature/sdk/ImmutableStructureTest.java b/src/test/java/dev/openfeature/sdk/ImmutableStructureTest.java index 6a0eed59b..7ec08c711 100644 --- a/src/test/java/dev/openfeature/sdk/ImmutableStructureTest.java +++ b/src/test/java/dev/openfeature/sdk/ImmutableStructureTest.java @@ -73,6 +73,19 @@ void MutatingGetInstantValueShouldNotChangeOriginalValue() { assertEquals(now, structure.getValue(KEY).asInstant()); } + @Test + void getValueShouldPreserveInstantPrecision() { + String KEY = "key"; + Instant instant = Instant.ofEpochSecond(1_700_000_000L, 123_456_789L); + Map map = new HashMap<>(); + map.put(KEY, new Value(instant)); + ImmutableStructure structure = new ImmutableStructure(map); + + assertEquals(instant, structure.getValue(KEY).asInstant()); + assertEquals(instant, structure.asMap().get(KEY).asInstant()); + assertEquals(instant, structure.asObjectMap().get(KEY)); + } + @Test void MutatingGetStructureValueShouldNotChangeOriginalValue() { String KEY = "key";