From 5e19adc1728949247bc74ef451dc32cb43c1e51e Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Fri, 20 Nov 2026 00:09:02 -0800 Subject: [PATCH 1/5] ci: resolve zizmor findings across workflows Co-Authored-By: Claude Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 2 +- .github/zizmor.yml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .github/zizmor.yml diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 31d485da..82e4dd4d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -59,9 +59,9 @@ jobs: publish: name: Publish - needs: changelog if: needs.changelog.outputs.hasChangesets == 'false' && needs.changelog.outputs.releaseExists == 'false' runs-on: ubuntu-latest + needs: changelog environment: publish outputs: releaseExists: ${{ steps.check.outputs.exists }} diff --git a/.github/zizmor.yml b/.github/zizmor.yml new file mode 100644 index 00000000..baf8b46e --- /dev/null +++ b/.github/zizmor.yml @@ -0,0 +1,6 @@ +rules: + self-repository: + ignore: + # these workflows build dist/ at runtime and test the checked out ref + - develop.yml + - integration.yml From 4b2831735ed4b8c63dfde3ddd91e8747802ac4b7 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Fri, 20 Nov 2026 00:17:56 -0800 Subject: [PATCH 2/5] ci: inline the zizmor self-repository ignores Co-Authored-By: Claude Co-Authored-By: Claude Opus 5.5 --- .github/workflows/develop.yml | 18 +++++++++--------- .github/workflows/integration.yml | 30 +++++++++++++++--------------- .github/zizmor.yml | 6 ------ 3 files changed, 24 insertions(+), 30 deletions(-) delete mode 100644 .github/zizmor.yml diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml index 257c09f1..3c97aa11 100644 --- a/.github/workflows/develop.yml +++ b/.github/workflows/develop.yml @@ -27,7 +27,7 @@ jobs: run: npm run build - name: Start a workflow with a webhook trigger id: wfb - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_WEBHOOK_TRIGGER }} @@ -40,7 +40,7 @@ jobs: status: ${{ job.status }} - name: Post a token message into channel id: api - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -50,7 +50,7 @@ jobs: text: ":checkered_flag: Action happens at " - name: Initiate the deployment sequence id: slack - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -66,7 +66,7 @@ jobs: value: "In Progress" - name: Write starting statistics id: stats - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -79,7 +79,7 @@ jobs: run: sleep 3 - name: Launch time is now id: finished - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.update @@ -95,7 +95,7 @@ jobs: short: true value: "Completed" - name: Include ending statistics - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -105,7 +105,7 @@ jobs: text: "Finished at `${{ steps.finished.outputs.time }}`" thread_ts: "${{ steps.stats.outputs.thread_ts }}" - name: Celebrate wins - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: reactions.add @@ -116,7 +116,7 @@ jobs: name: "eye-in-speech-bubble" - name: Upload this workflow file id: file - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: files.uploadV2 @@ -127,7 +127,7 @@ jobs: file: .github/workflows/develop.yml filename: action.yml - name: Write one final webhook - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_INCOMING_WEBHOOK }} diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index d33d9712..c3d559af 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -70,7 +70,7 @@ jobs: - name: "test(wfb): send a payload to workflow builder via webhook trigger" id: wfb - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_WEBHOOK_TRIGGER }} @@ -89,7 +89,7 @@ jobs: - name: "test(api): post a message to channel" id: message - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -105,7 +105,7 @@ jobs: - name: "test(api): post a multiline message" # https://github.com/slackapi/slack-github-action/issues/637 id: multiline - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -123,7 +123,7 @@ jobs: - name: "test(api): post a message with blocks" id: blocks - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -145,7 +145,7 @@ jobs: - name: "test(api): post a threaded message" id: timer - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -165,7 +165,7 @@ jobs: - name: "test(api): update the original message" id: finished - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.update @@ -183,7 +183,7 @@ jobs: - name: "test(api): post another threaded message" id: done - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -195,7 +195,7 @@ jobs: - name: "test(api): post a file into a channel" id: file - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: files.uploadV2 @@ -207,7 +207,7 @@ jobs: filename: integration.yml - name: "test(api): react to the completed update message" - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: reactions.add @@ -224,7 +224,7 @@ jobs: - name: "test(incoming): post a message via incoming webhook" id: incoming - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_INCOMING_WEBHOOK }} @@ -250,7 +250,7 @@ jobs: - name: "test(incoming): post a message via payload file" id: payload_file - uses: ./ + uses: ./ # zizmor: ignore[self-repository] with: errors: true payload-file-path: ./.github/resources/.slack/incoming-webhook.json @@ -288,7 +288,7 @@ jobs: - name: "test(cli): run a slack cli version check" id: version - uses: ./cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "version" @@ -307,7 +307,7 @@ jobs: - name: "test(cli): run an unknown command" id: unknown continue-on-error: true - uses: ./cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "off" @@ -328,13 +328,13 @@ jobs: run: mv .github/resources/.slack .slack - name: "test(cli): validate the app manifest" - uses: ./cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "manifest" token: ${{ secrets.SLACK_SERVICE_TOKEN }} - name: "test(cli): deploy the app" - uses: ./cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "deploy --app ${{ vars.SLACK_APP_ID }} --hide-triggers --force" token: ${{ secrets.SLACK_SERVICE_TOKEN }} diff --git a/.github/zizmor.yml b/.github/zizmor.yml deleted file mode 100644 index baf8b46e..00000000 --- a/.github/zizmor.yml +++ /dev/null @@ -1,6 +0,0 @@ -rules: - self-repository: - ignore: - # these workflows build dist/ at runtime and test the checked out ref - - develop.yml - - integration.yml From d002b51c1b7a21287de90e095e8582f7db6bf867 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Fri, 20 Nov 2026 00:20:53 -0800 Subject: [PATCH 3/5] ci: use self-repository syntax for in-repo actions Co-Authored-By: Claude Co-Authored-By: Claude Opus 5.5 --- .github/workflows/develop.yml | 18 +++++++++--------- .github/workflows/integration.yml | 30 +++++++++++++++--------------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml index 3c97aa11..61febda8 100644 --- a/.github/workflows/develop.yml +++ b/.github/workflows/develop.yml @@ -27,7 +27,7 @@ jobs: run: npm run build - name: Start a workflow with a webhook trigger id: wfb - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true webhook: ${{ secrets.SLACK_WEBHOOK_TRIGGER }} @@ -40,7 +40,7 @@ jobs: status: ${{ job.status }} - name: Post a token message into channel id: api - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -50,7 +50,7 @@ jobs: text: ":checkered_flag: Action happens at " - name: Initiate the deployment sequence id: slack - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -66,7 +66,7 @@ jobs: value: "In Progress" - name: Write starting statistics id: stats - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -79,7 +79,7 @@ jobs: run: sleep 3 - name: Launch time is now id: finished - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.update @@ -95,7 +95,7 @@ jobs: short: true value: "Completed" - name: Include ending statistics - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -105,7 +105,7 @@ jobs: text: "Finished at `${{ steps.finished.outputs.time }}`" thread_ts: "${{ steps.stats.outputs.thread_ts }}" - name: Celebrate wins - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: reactions.add @@ -116,7 +116,7 @@ jobs: name: "eye-in-speech-bubble" - name: Upload this workflow file id: file - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: files.uploadV2 @@ -127,7 +127,7 @@ jobs: file: .github/workflows/develop.yml filename: action.yml - name: Write one final webhook - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true webhook: ${{ secrets.SLACK_INCOMING_WEBHOOK }} diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index c3d559af..fa840b0c 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -70,7 +70,7 @@ jobs: - name: "test(wfb): send a payload to workflow builder via webhook trigger" id: wfb - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true webhook: ${{ secrets.SLACK_WEBHOOK_TRIGGER }} @@ -89,7 +89,7 @@ jobs: - name: "test(api): post a message to channel" id: message - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -105,7 +105,7 @@ jobs: - name: "test(api): post a multiline message" # https://github.com/slackapi/slack-github-action/issues/637 id: multiline - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -123,7 +123,7 @@ jobs: - name: "test(api): post a message with blocks" id: blocks - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -145,7 +145,7 @@ jobs: - name: "test(api): post a threaded message" id: timer - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -165,7 +165,7 @@ jobs: - name: "test(api): update the original message" id: finished - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.update @@ -183,7 +183,7 @@ jobs: - name: "test(api): post another threaded message" id: done - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: chat.postMessage @@ -195,7 +195,7 @@ jobs: - name: "test(api): post a file into a channel" id: file - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: files.uploadV2 @@ -207,7 +207,7 @@ jobs: filename: integration.yml - name: "test(api): react to the completed update message" - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true method: reactions.add @@ -224,7 +224,7 @@ jobs: - name: "test(incoming): post a message via incoming webhook" id: incoming - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true webhook: ${{ secrets.SLACK_INCOMING_WEBHOOK }} @@ -250,7 +250,7 @@ jobs: - name: "test(incoming): post a message via payload file" id: payload_file - uses: ./ # zizmor: ignore[self-repository] + uses: $/ with: errors: true payload-file-path: ./.github/resources/.slack/incoming-webhook.json @@ -288,7 +288,7 @@ jobs: - name: "test(cli): run a slack cli version check" id: version - uses: ./cli # zizmor: ignore[self-repository] + uses: $/cli with: command: "version" @@ -307,7 +307,7 @@ jobs: - name: "test(cli): run an unknown command" id: unknown continue-on-error: true - uses: ./cli # zizmor: ignore[self-repository] + uses: $/cli with: command: "off" @@ -328,13 +328,13 @@ jobs: run: mv .github/resources/.slack .slack - name: "test(cli): validate the app manifest" - uses: ./cli # zizmor: ignore[self-repository] + uses: $/cli with: command: "manifest" token: ${{ secrets.SLACK_SERVICE_TOKEN }} - name: "test(cli): deploy the app" - uses: ./cli # zizmor: ignore[self-repository] + uses: $/cli with: command: "deploy --app ${{ vars.SLACK_APP_ID }} --hide-triggers --force" token: ${{ secrets.SLACK_SERVICE_TOKEN }} From 16e3efdb9f6887732c82fa269a1263654802a758 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Fri, 20 Nov 2026 00:24:59 -0800 Subject: [PATCH 4/5] ci: keep workspace-relative uses for steps that run the built dist Co-Authored-By: Claude Co-Authored-By: Claude Opus 5.5 --- .github/workflows/develop.yml | 18 +++++++++--------- .github/workflows/integration.yml | 22 +++++++++++----------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml index 61febda8..3c97aa11 100644 --- a/.github/workflows/develop.yml +++ b/.github/workflows/develop.yml @@ -27,7 +27,7 @@ jobs: run: npm run build - name: Start a workflow with a webhook trigger id: wfb - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_WEBHOOK_TRIGGER }} @@ -40,7 +40,7 @@ jobs: status: ${{ job.status }} - name: Post a token message into channel id: api - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -50,7 +50,7 @@ jobs: text: ":checkered_flag: Action happens at " - name: Initiate the deployment sequence id: slack - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -66,7 +66,7 @@ jobs: value: "In Progress" - name: Write starting statistics id: stats - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -79,7 +79,7 @@ jobs: run: sleep 3 - name: Launch time is now id: finished - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.update @@ -95,7 +95,7 @@ jobs: short: true value: "Completed" - name: Include ending statistics - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -105,7 +105,7 @@ jobs: text: "Finished at `${{ steps.finished.outputs.time }}`" thread_ts: "${{ steps.stats.outputs.thread_ts }}" - name: Celebrate wins - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: reactions.add @@ -116,7 +116,7 @@ jobs: name: "eye-in-speech-bubble" - name: Upload this workflow file id: file - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: files.uploadV2 @@ -127,7 +127,7 @@ jobs: file: .github/workflows/develop.yml filename: action.yml - name: Write one final webhook - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_INCOMING_WEBHOOK }} diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index fa840b0c..cec54b5b 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -70,7 +70,7 @@ jobs: - name: "test(wfb): send a payload to workflow builder via webhook trigger" id: wfb - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_WEBHOOK_TRIGGER }} @@ -89,7 +89,7 @@ jobs: - name: "test(api): post a message to channel" id: message - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -105,7 +105,7 @@ jobs: - name: "test(api): post a multiline message" # https://github.com/slackapi/slack-github-action/issues/637 id: multiline - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -123,7 +123,7 @@ jobs: - name: "test(api): post a message with blocks" id: blocks - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -145,7 +145,7 @@ jobs: - name: "test(api): post a threaded message" id: timer - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -165,7 +165,7 @@ jobs: - name: "test(api): update the original message" id: finished - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.update @@ -183,7 +183,7 @@ jobs: - name: "test(api): post another threaded message" id: done - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: chat.postMessage @@ -195,7 +195,7 @@ jobs: - name: "test(api): post a file into a channel" id: file - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: files.uploadV2 @@ -207,7 +207,7 @@ jobs: filename: integration.yml - name: "test(api): react to the completed update message" - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true method: reactions.add @@ -224,7 +224,7 @@ jobs: - name: "test(incoming): post a message via incoming webhook" id: incoming - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true webhook: ${{ secrets.SLACK_INCOMING_WEBHOOK }} @@ -250,7 +250,7 @@ jobs: - name: "test(incoming): post a message via payload file" id: payload_file - uses: $/ + uses: ./ # zizmor: ignore[self-repository] with: errors: true payload-file-path: ./.github/resources/.slack/incoming-webhook.json From 7c72c4d1c4d55cbeb47082e78bae09927c6a995d Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Fri, 20 Nov 2026 11:48:23 -0800 Subject: [PATCH 5/5] ci: keep workspace-relative uses for the cli action steps Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com> Co-Authored-By: Claude Co-Authored-By: Claude Opus 5.5 --- .github/workflows/integration.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index cec54b5b..c3d559af 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -288,7 +288,7 @@ jobs: - name: "test(cli): run a slack cli version check" id: version - uses: $/cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "version" @@ -307,7 +307,7 @@ jobs: - name: "test(cli): run an unknown command" id: unknown continue-on-error: true - uses: $/cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "off" @@ -328,13 +328,13 @@ jobs: run: mv .github/resources/.slack .slack - name: "test(cli): validate the app manifest" - uses: $/cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "manifest" token: ${{ secrets.SLACK_SERVICE_TOKEN }} - name: "test(cli): deploy the app" - uses: $/cli + uses: ./cli # zizmor: ignore[self-repository] with: command: "deploy --app ${{ vars.SLACK_APP_ID }} --hide-triggers --force" token: ${{ secrets.SLACK_SERVICE_TOKEN }}