From 48127ad3c7a34d6d5a6f2578cd3bbf5ba103659c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Weberru=C3=9F?= Date: Tue, 17 Nov 2026 15:34:19 +0000 Subject: [PATCH] fix(assistant): guide incomplete setup into scoped questions --- .../app/apps/api/src/assistant/editor.ts | 44 +++- .../assistant/knowledge-topics.generated.ts | 55 ++--- .../apps/api/src/assistant/model-serving.ts | 100 ++++++++- .../app/scripts/assistant-journey.ts | 8 + .../app/scripts/assistant-scenarios.ts | 98 +++++++++ .../app/tests/assistant-editor.test.ts | 202 ++++++++++++++++++ .../app/tests/assistant-scenarios.test.ts | 25 ++- .../docs/assistant-knowledge/README.de.md | 20 ++ .../docs/assistant-knowledge/README.md | 18 ++ .../docs/assistant-knowledge/devops-git.de.md | 8 + .../docs/assistant-knowledge/devops-git.md | 38 ++-- .../docs/assistant-knowledge/manifest.json | 8 +- .../docs/assistant-test-catalogue.json | 99 ++++++++- 13 files changed, 665 insertions(+), 58 deletions(-) diff --git a/landing-zone-configurator/app/apps/api/src/assistant/editor.ts b/landing-zone-configurator/app/apps/api/src/assistant/editor.ts index 2f250671..3eaa9e96 100644 --- a/landing-zone-configurator/app/apps/api/src/assistant/editor.ts +++ b/landing-zone-configurator/app/apps/api/src/assistant/editor.ts @@ -64,6 +64,10 @@ export const assistantEditorPolicies: Record< freeTextQuestions: ["audit_logs.acl"], }, observability: { freeTextQuestions: ["observability.acl"] }, + devops: { + creationDecisions: ["devops.git_flavor", "devops.allowed_network_ranges"], + freeTextQuestions: ["devops.git_flavor", "devops.allowed_network_ranges"], + }, }; export function assistantEditorProposalPath(path: string): string | null { @@ -745,6 +749,12 @@ export function assistantEditorPublicValues( return result; } +export class AssistantEditorSourceError extends Error { + constructor(readonly path: string) { + super("assistant_editor_value_unconfirmed"); + } +} + export function validateAssistantEditorSources( change: AssistantEditorChange, current: Record, @@ -761,7 +771,7 @@ export function validateAssistantEditorSources( saved.includes(value) || userSources.some((source) => source.includes(value)) || productValues.includes(value); - const visit = (value: JsonValue, key: string): void => { + const visit = (value: JsonValue, key: string, path: string): void => { if (typeof value === "string") { const references = value.match( @@ -783,14 +793,38 @@ export function validateAssistantEditorSources( !userSources.some((source) => source.includes(value)) && !productValues.includes(value)) ) - throw new Error("assistant_editor_value_unconfirmed"); + throw new AssistantEditorSourceError(path); } else if (Array.isArray(value)) { - for (const item of value) visit(item, key); + for (const item of value) visit(item, key, `${path}[*]`); } else if (value) { - for (const [child, item] of Object.entries(value)) visit(item, child); + for (const [child, item] of Object.entries(value)) + visit(item, child, `${path}.${child}`); } }; - visit(change.value, change.path); + visit(change.value, change.path, change.path); +} + +const gitCreationQuestions = { + en: { + "devops.git_flavor": + "Which Git size should the draft use? Choose an available Git plan or describe your capacity needs.", + "devops.allowed_network_ranges": + "Which source IP addresses or networks should be allowed to access Git? Enter your actual CIDRs. Leaving this unanswered does not authorize public access.", + }, + de: { + "devops.git_flavor": + "Welche Git-Größe soll der Entwurf verwenden? Wähle einen verfügbaren Git-Tarif oder beschreibe deinen Kapazitätsbedarf.", + "devops.allowed_network_ranges": + "Welche Quell-IP-Adressen oder Netze sollen auf Git zugreifen dürfen? Gib deine tatsächlichen CIDRs an. Eine fehlende Antwort erlaubt keinen öffentlichen Zugriff.", + }, +}; + +export function assistantGitQuestion(path: string, language: "de" | "en") { + const text = + gitCreationQuestions[language][ + path as keyof typeof gitCreationQuestions.en + ]; + return text ? { path, text, options: [] as string[] } : null; } export function applyAssistantEditorChange( diff --git a/landing-zone-configurator/app/apps/api/src/assistant/knowledge-topics.generated.ts b/landing-zone-configurator/app/apps/api/src/assistant/knowledge-topics.generated.ts index df8660e5..891ea0f7 100644 --- a/landing-zone-configurator/app/apps/api/src/assistant/knowledge-topics.generated.ts +++ b/landing-zone-configurator/app/apps/api/src/assistant/knowledge-topics.generated.ts @@ -53,7 +53,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -127,7 +127,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -219,7 +219,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -289,7 +289,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -384,7 +384,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -455,12 +455,12 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts", sha256: - "6d04daccbbbe8e65c649ce891cbe1adf4c5e6f1d8ec54a945b11569cf0735aca", + "7af8d5469272cec70e60b74a241622e4613844b555bd339c1cd0006cd40199a4", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -564,7 +564,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -628,7 +628,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -699,7 +699,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -790,7 +790,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -900,7 +900,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1082,7 +1082,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1213,7 +1213,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1238,8 +1238,8 @@ export const assistantKnowledgeTopics = { { id: "devops-git", file: "devops-git.md", - version: 1, - checkedOn: "2026-10-10", + version: 2, + checkedOn: "2026-11-17", qualification: "local-draft-not-reviewed-release", groups: ["platform"], mandatory: false, @@ -1269,7 +1269,12 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", + }, + { + path: "landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts", + sha256: + "7af8d5469272cec70e60b74a241622e4613844b555bd339c1cd0006cd40199a4", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1287,9 +1292,9 @@ export const assistantKnowledgeTopics = { ], source: "landing-zone-configurator/docs/assistant-knowledge/devops-git.md", - text: "# DevOps Git Service\n\n## Purpose\n\nExplicit managed Git, separate from GitHub login, forks and Configurator CI.\n\n## Accelerator Contract\n\ndevops=null skips the module. The root derives project, ownership and naming,\npassing git_flavor and allowed_network_ranges. git_flavor defaults to null,\nNOT git-10/git-100: null creates no Git instance. An ACL-only object does not\nenable Git. Root wiring, not child-module parameters alone, defines support.\nReal sizes and regional availability require authorized catalogues.\n\n## Dependencies\n\nManagement/governance, identity foundations, provider rights and deliberate ACLs.\nA repository fork proves neither provisioned Git nor service-account rights.\n\n## Dialogue\n\nClarify Git need, capacity, operator and access networks. The allow-all ACL\ndefault is NOT public-access consent. There is no enabled native flavor default:\nif Git is wanted without a chosen/verified flavor, explain null and ask instead\nof inventing git-10. Explicit user flavor choices are reviewable, not availability\nproof. Do not infer runners, integrations, migrations or secrets.\n\n## Examples\n\ndevops=null opts out. A chosen git_flavor plus deliberate allowed_network_ranges\ncan propose Git. git-10 illustrates syntax, not entitlement or capacity.\n\n## Limits\n\nTyped native Editor proposals change only the local draft on acceptance.\nACLs do not qualify backup/restore, migration, SSO or CI execution. No arbitrary\nGit appliances, availability, prices or performance promises.\n\n## Credentials\n\nProvisioning and Git-user access are separate. No PATs, private SSH keys, Git\npasswords or CI secrets in chat; no hidden Configurator profile-ID dependency.\n\n## Sources\n\nRoot calls, DevOps variables and provider configuration in the manifest.\nRefresh engine/source bindings after review; live product facts stay separate.", + text: '# DevOps Git Service\n\n## Purpose\n\nCentral managed Git, separate from GitHub login, forks and Configurator CI.\n\n## Accelerator Contract\n\nRoot derives project, ownership and naming; passes git_flavor and\nallowed_network_ranges. devops=null skips deployment. git_flavor defaults to\nnull, NOT git-10/git-100: null or an ACL-only object creates no Git instance.\nLive catalogues are needed for real sizes and regional availability.\n\n## Dependencies\n\nManagement/governance, identity foundations, provider rights and deliberate ACLs.\nA fork proves neither provisioned Git nor service-account rights.\n\n## Dialogue\n\nBroad setup requests ("Please add a central git instance to the config") start\na dialogue. Ask missing size/capacity and access decisions, preserving user\nanswers across turns. Only propose a complete new component. There is no enabled\nflavor default: ask instead of inventing git-10. A verified catalogue can ground\na labelled recommendation, never entitlement or availability. Ask actual CIDRs\nas free text, without invented examples or preset networks. A blank answer never\nmeans consent to allow all. Separate operator, runners and integrations; do not\ninfer migrations or secrets.\n\n## Examples\n\ndevops=null opts out. Selected git_flavor plus deliberate allowed_network_ranges\ncan propose Git. git-10 illustrates syntax, not entitlement or capacity.\n\n## Limits\n\nEditor acceptance changes only the local draft. ACLs do not qualify backup/restore,\nmigration, SSO or CI execution. No arbitrary Git appliances, prices, performance\nor availability promises. Root wiring, not child parameters, defines support.\n\n## Credentials\n\nProvisioning and Git-user access are separate. No PATs, SSH private keys, Git\npasswords or CI secrets in chat; no hidden Configurator profile-ID dependency.\n\n## Sources\n\nRoot calls, DevOps variables and provider configuration in the manifest.\nRefresh source bindings after review; live product facts stay separate.\n', sha256: - "272e93daa20f89e78ea5596daeae15a782626e036a7c5c2224468dac5e591666", + "a9bb755e1f46889b295811afa6d01bacf047405ad3db14fa66df59984822ce21", }, { id: "platform-kubernetes", @@ -1338,7 +1343,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1500,7 +1505,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1586,7 +1591,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1649,7 +1654,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", @@ -1735,7 +1740,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts", sha256: - "6d04daccbbbe8e65c649ce891cbe1adf4c5e6f1d8ec54a945b11569cf0735aca", + "7af8d5469272cec70e60b74a241622e4613844b555bd339c1cd0006cd40199a4", }, { path: "landing-zone-configurator/docs/application-execution-lifecycle.md", @@ -1775,7 +1780,7 @@ export const assistantKnowledgeTopics = { { path: "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", sha256: - "922cfe902b43266dcd23b8382e0d7369fbd317311c734808aa5b4a423f6b3536", + "3ce11af46cc6445b44b44533666154cd1699dedbc84c4901cc41a73ec11c875c", }, { path: "landing-zone-configurator/app/apps/api/src/assistant/serving-schema.ts", diff --git a/landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts b/landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts index f4151f5f..10171173 100644 --- a/landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts +++ b/landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts @@ -48,6 +48,7 @@ import { validateDialogue, } from "./dialogue.js"; import { + AssistantEditorSourceError, assertAssistantEditorValue, assistantAuditCreationChoices, assistantAuditCreationQuestions, @@ -61,6 +62,7 @@ import { assistantEditorPolicies, assistantEditorProposalPath, assistantEditorResponseSchema, + assistantGitQuestion, assistantTemplateFields, mergeAssistantEditorValue, validateAssistantEditorSources, @@ -2759,6 +2761,15 @@ export class AssistantModelServing { const questions = [ ...assistantQuestionFields() .filter((field) => fields.includes(field.path)) + .filter( + (field) => + current.devops != null || + !editorRoots.has("devops") || + !field.path.startsWith("devops") || + ( + assistantEditorPolicies.devops?.creationDecisions ?? [] + ).includes(field.path), + ) .map((field) => field.path), ...(templateTopic ? ["projectTemplates"] : []), ]; @@ -2815,7 +2826,8 @@ For an additional DNS zone, emit the actual collection change containing the req templateSetup contains source-checked USER decisions: its kinds and localNetworks are answered requirements, not questions to repeat. Its fields is the allowed template setting scope; the schema excludes unrequested services and policies. delegateNaming=true authorizes descriptive template display names and valid stable template keys; they are not Cloud IDs. When saved region and the Corporate area are unambiguous, these decisions suffice for complete name/kind/region/settings template proposals. Optional parameter policies and subnet overrides are not mandatory setup questions. When templateSetup.resolvedDefaults is non-null, the server has resolved every essential choice for this network-only request: use its region, and its networkAreaKey as settings.network_area_key for Corporate. Template kinds, local networks and delegated naming are already answered. Return questions=[] as required by the schema; do not ask the user to repeat native keys, naming, subnet defaults or other unrequested optional settings. Missing or ambiguous Corporate areas, missing region/naming and additional service choices retain the normal question contract. New component objects expose all their typed property slots: fill every explicitly requested value, use null only for unrequested native defaults. Never invent extra retention values. Required non-null creation decisions need actual user consent; otherwise ask questions with changes=[]. New map entries require all native mandatory fields, including Kubernetes region and node-pool name. Use existing nested paths for partial updates, preserving sibling values. All replies describe PROPOSALS, not completed setup. Field acceptance changes only the local draft, saving remains separate; no deployment, permissions granted, publication or Plan/Apply. Return the supplied JSON schema only. -Reviewed knowledge: ${JSON.stringify({ fields: draftFields, ...topicKnowledge })}`, +Reviewed knowledge: ${JSON.stringify({ fields: draftFields, ...topicKnowledge })} +CURRENT RESPONSE LANGUAGE: Your JSON must contain replyLanguage. For an English CURRENT USER request set replyLanguage=en and write all explanation/questions in English. For a German request set replyLanguage=de and write German. For a values-only answer continue the latest natural-language USER turn. The language of these curated rules, schema defaults or earlier ASSISTANT text does not choose the response language. An ordinary setup request receives focused questions or a clearly labelled, grounded best-practice proposal; never blame the user for missing native field syntax.`, }, { role: "user", @@ -2863,7 +2875,6 @@ Reviewed knowledge: ${JSON.stringify({ fields: draftFields, ...topicKnowledge }) dialogueSchema.extend({ replyLanguage: z .enum(["de", "en"]) - .default("de") .describe( "Language of the current user, or the latest natural-language user turn for numeric follow-ups.", ), @@ -2887,14 +2898,64 @@ Reviewed knowledge: ${JSON.stringify({ fields: draftFields, ...topicKnowledge }) : [], ), ]); + let responseLanguage: "de" | "en" = "de"; try { const { replyLanguage, ...provided } = z .object({ replyLanguage: z.enum(["de", "en"]).default("de") }) .passthrough() .parse(answer); + responseLanguage = replyLanguage; const dialogue = validateDialogue(provided, referenceIds); - changeListSchema.parse(dialogue.changes); questionListSchema.parse(dialogue.questions); + if (editorRoots.has("devops") && current.devops == null) { + const proposed = dialogue.changes.find( + (change) => + change.path === "devops" && + change.operation !== "default" && + change.value !== null, + ); + const missing = proposed + ? (assistantEditorPolicies.devops?.creationDecisions ?? []).filter( + (path) => { + const choice = objectValue( + proposed.value as Parameters[0], + )[path.split(".")[1] ?? ""]; + return ( + choice == null || + (typeof choice === "string" && !choice.trim()) || + (Array.isArray(choice) && !choice.length) + ); + }, + ) + : []; + for (const path of missing) { + const question = assistantGitQuestion(path, replyLanguage); + if ( + question && + !dialogue.questions.some((existing) => existing.path === path) + ) + dialogue.questions.push(question); + } + dialogue.questions = dialogue.questions.map( + (question) => + assistantGitQuestion(question.path, replyLanguage) ?? question, + ); + if ( + dialogue.questions.some((question) => + question.path.startsWith("devops."), + ) + ) { + dialogue.changes = dialogue.changes.filter( + (change) => change.path !== "devops", + ); + if (editorRoots.size === 1) + dialogue.explanation = + replyLanguage === "en" + ? "I can prepare central Git. Please complete the remaining size and access choices first. Nothing has been changed." + : "Ich kann zentrales Git vorbereiten. Bitte beantworte zuerst die noch offenen Fragen zu Größe und Zugriff. Noch nichts geändert."; + } + } + changeListSchema.parse(dialogue.changes); if ( current.audit_logs == null && editorRoots.has("audit_logs") && @@ -3060,6 +3121,39 @@ Reviewed knowledge: ${JSON.stringify({ fields: draftFields, ...topicKnowledge }) } return dialogue; } catch (error) { + if (error instanceof AssistantEditorSourceError) { + const path = questions + .filter( + (candidate) => + !candidate.endsWith("[*]") && + (error.path === candidate || + error.path.startsWith(`${candidate}.`) || + error.path.startsWith(`${candidate}[*]`)), + ) + .sort((a, b) => b.length - a.length)[0]; + if (path) { + const english = responseLanguage === "en"; + return validateDialogue( + { + explanation: english + ? "I need one more confirmed choice to prepare your change. Nothing has been changed." + : "Für deinen Vorschlag fehlt noch eine bestätigte Auswahl. Noch nichts geändert.", + questions: [ + assistantGitQuestion(path, responseLanguage) ?? { + path, + text: english + ? `Which value should I use for ${path}? Please provide your choice or select a verified catalogue option.` + : `Welchen Wert soll ich für ${path} verwenden? Bitte nenne deine Auswahl oder wähle eine geprüfte Katalogoption.`, + options: [], + }, + ], + changes: [], + references: [intent.topic], + }, + referenceIds, + ); + } + } if (error instanceof AssistantInferenceError) throw error; if (error instanceof z.ZodError) throw new AssistantInferenceError("dialogue_schema"); diff --git a/landing-zone-configurator/app/scripts/assistant-journey.ts b/landing-zone-configurator/app/scripts/assistant-journey.ts index b8c38102..0ca207d5 100644 --- a/landing-zone-configurator/app/scripts/assistant-journey.ts +++ b/landing-zone-configurator/app/scripts/assistant-journey.ts @@ -143,6 +143,14 @@ const steps: Step[] = [ "observability.metrics_retention_days": 30, }, }, + { + id: "devops-setup", + message: + "Please add a central git instance to the config. I have not selected its size or access networks yet.", + reference: "devops-git", + roots: ["devops"], + questionsOnly: true, + }, { id: "devops", message: diff --git a/landing-zone-configurator/app/scripts/assistant-scenarios.ts b/landing-zone-configurator/app/scripts/assistant-scenarios.ts index 77ee77e7..0e59ef3e 100644 --- a/landing-zone-configurator/app/scripts/assistant-scenarios.ts +++ b/landing-zone-configurator/app/scripts/assistant-scenarios.ts @@ -171,6 +171,8 @@ export type AssistantScenario = { requiredOverviewFields?: readonly string[]; editorExpected?: { path: string; value: JsonValue }; auditQuestionPaths?: readonly string[]; + setupQuestionPaths?: readonly string[]; + expectedLanguage?: "de" | "en"; dnsRole?: "roles" | "secondary" | "draft"; templateExpected?: ("public" | "corporate")[]; applicationAccess?: @@ -681,6 +683,63 @@ export const assistantScenarios: readonly AssistantScenario[] = [ "Bitte Bucket-Namensschema im lokalen Entwurf ausdrücklich auf bucket_naming=project-id setzen, damit die vollständige jeweilige Projekt-ID enthalten ist. Keine sonstigen Änderungen, kein Plan oder Apply.", editorExpected: { path: "bucket_naming", value: "project-id" }, }, + ...[ + { + id: "editor-devops-setup-en", + message: "Please add a central git instance to the config", + paths: ["devops.git_flavor", "devops.allowed_network_ranges"], + }, + { + id: "editor-devops-setup-de", + message: + "Bitte eine zentrale Git-Instanz in die Konfiguration aufnehmen.", + paths: ["devops.git_flavor", "devops.allowed_network_ranges"], + }, + { + id: "editor-devops-size-only", + message: + "Please add central Git, using git-10. I have not chosen the access networks yet.", + paths: ["devops.allowed_network_ranges"], + }, + { + id: "editor-devops-networks-only", + message: + "Please add central Git, accessible only from 203.0.113.0/24. I have not selected its size yet.", + paths: ["devops.git_flavor"], + }, + ].map(({ id, message, paths }) => ({ + id, + message, + topic: "devops-git", + fixture: "baseline" as const, + setupQuestionPaths: paths, + expectedLanguage: id.endsWith("-de") ? ("de" as const) : ("en" as const), + })), + { + id: "editor-devops-followup", + topic: "devops-git", + fixture: "baseline", + message: "Use git-10 and allow access only from 203.0.113.0/24.", + history: [ + { + role: "user", + content: "Please add a central git instance to the config", + }, + { + role: "assistant", + content: + "Which Git size and source networks should the draft use? No choice has been made yet.", + }, + ], + expectedLanguage: "en", + editorExpected: { + path: "devops", + value: { + git_flavor: "git-10", + allowed_network_ranges: ["203.0.113.0/24"], + }, + }, + }, { id: "editor-devops", topic: "devops-git", @@ -2050,6 +2109,45 @@ export function validateAssistantScenario( } return { dialogue, failures }; } + if (scenario.expectedLanguage) { + const text = + dialogue.explanation + + " " + + dialogue.questions.map((question) => question.text).join(" "); + if ( + scenario.expectedLanguage === "en" && + /\b(?:Welche|Welchen|Noch nichts|Bitte beantworte|gespeichert|Vorschlag|Entwurf)\b/.test( + text, + ) + ) + failures.push("dialogue_language_mismatch"); + if ( + scenario.expectedLanguage === "de" && + /\b(?:Which|Nothing has|Please complete)\b/.test(text) + ) + failures.push("dialogue_language_mismatch"); + } + if (scenario.setupQuestionPaths) { + if ( + dialogue.changes.length || + !dialogue.questions.length || + dialogue.questions.some( + (question) => !scenario.setupQuestionPaths!.includes(question.path), + ) + ) + failures.push("setup_must_ask_missing_choices_without_changes"); + if ( + dialogue.questions.some( + (question) => + (question.options?.length ?? 0) > 0 || + /(?:leave|leaving).*empty.*allow|192\.168|10\.0\.0|0\.0\.0\.0|git-100|git-10/i.test( + question.text, + ), + ) + ) + failures.push("setup_invented_defaults_or_network_options"); + return { dialogue, failures }; + } if (scenario.auditQuestionPaths) { if ( dialogue.changes.length || diff --git a/landing-zone-configurator/app/tests/assistant-editor.test.ts b/landing-zone-configurator/app/tests/assistant-editor.test.ts index 84efd213..81208136 100644 --- a/landing-zone-configurator/app/tests/assistant-editor.test.ts +++ b/landing-zone-configurator/app/tests/assistant-editor.test.ts @@ -4681,3 +4681,205 @@ it.each([ expect(assistantAuditManagedCoverage(message, [])).toBe(expected); }, ); + +it.each([ + { + topic: "devops-git", + root: "devops", + value: { git_flavor: "git-10", allowed_network_ranges: ["203.0.113.0/24"] }, + message: "Please add a central git instance to the config", + path: "devops.allowed_network_ranges", + }, + { + topic: "devops-git", + root: "devops", + value: { git_flavor: "git-10", allowed_network_ranges: ["0.0.0.0/0"] }, + message: "Please add central Git using git-10.", + path: "devops.allowed_network_ranges", + }, + { + topic: "observability", + root: "observability", + value: { + plan_name: "Observability-Starter-EU01", + acl: ["203.0.113.0/24"], + metrics_retention_days: 30, + }, + message: "Please add central monitoring, accessible from 203.0.113.0/24.", + path: "observability.plan_name", + }, + { + topic: "identity-foundations", + root: "labels", + value: { contact_email: "invented@example.test" }, + message: "Please add a contact label.", + path: "labels", + }, +])( + "asks a scoped follow-up instead of accepting an unconfirmed $path", + async ({ topic, root, value, message, path }) => { + const original = draft(); + const before = structuredClone(original); + const native = inputDefinition(root).type; + const constructorValues = + typeof native !== "string" && native[0] === "object" + ? { + ...Object.fromEntries( + Object.keys(native[1]).map((key) => [key, null]), + ), + ...value, + } + : value; + const result = await collectionModel( + { + topic, + mode: "draft", + requirements: [], + editorContract: true, + editorInputs: [root], + }, + { + ...response([patch(root, constructorValues)]), + replyLanguage: "en", + references: [topic], + }, + ).converse( + knowledgeSelection(), + assistantPublicValues(original), + [], + message, + ); + expect(result.changes).toEqual([]); + expect(result.questions).toHaveLength(1); + expect(result.questions[0]?.path).toBe(path); + expect(result.questions[0]?.options).toEqual([]); + expect(JSON.stringify(result)).not.toMatch( + /invented@example|invented-plan|0\.0\.0\.0/, + ); + expect(applyAssistantChanges(original, result.changes)).toEqual(before); + }, +); + +it("retains catalogue-grounded recommendations as reviewable draft proposals", async () => { + const original = draft(); + const result = await collectionModel( + { + topic: "devops-git", + mode: "draft", + requirements: [], + editorContract: true, + editorInputs: ["devops"], + }, + { + ...response([ + patch("devops", { + git_flavor: "git-10", + allowed_network_ranges: ["203.0.113.0/24"], + }), + ]), + replyLanguage: "en", + references: ["devops-git"], + }, + ).converse( + knowledgeSelection(), + assistantPublicValues(original), + [], + "Suggest central Git. Access only from 203.0.113.0/24.", + { + regions: [ + { + region: "eu01", + fetchedAt: null, + products: { + gitFlavors: { + status: "available", + options: [{ value: "git-10", label: "Git small" }], + totalOptions: 1, + truncated: false, + }, + }, + }, + ], + }, + ); + expect(result.questions).toEqual([]); + expect( + compileCommonConfiguration(applyAssistantChanges(original, result.changes)) + .devops, + ).toEqual({ + git_flavor: "git-10", + allowed_network_ranges: ["203.0.113.0/24"], + }); +}); + +it("requires a complete new Git proposal", () => { + const schema = assistantEditorChangeSchema( + "devops", + undefined, + "serving", + null, + ); + expect( + schema.safeParse(patch("devops", { git_flavor: "git-10" })).success, + ).toBe(false); + expect( + schema.safeParse( + patch("devops", { allowed_network_ranges: ["203.0.113.0/24"] }), + ).success, + ).toBe(false); +}); + +it.each(["de", "en"] as const)( + "withholds partial Git creation while a decision remains open (%s)", + async (language) => { + const result = await collectionModel( + { + topic: "devops-git", + mode: "draft", + requirements: [], + editorContract: true, + editorInputs: ["devops"], + }, + { + ...response( + [ + patch("devops", { + git_flavor: "", + allowed_network_ranges: ["203.0.113.0/24"], + }), + ], + [{ path: "devops.git_flavor", text: "Choose." }], + ), + replyLanguage: language, + references: ["devops-git"], + }, + (request) => { + if (request.response_format.json_schema.name !== "editor_dialogue") + return; + const schema = request.response_format.json_schema.schema as { + required: string[]; + properties: Record; + }; + expect(schema.required).toContain("replyLanguage"); + const questions = JSON.stringify(schema.properties.questions); + expect(questions).toContain("devops.git_flavor"); + expect(questions).toContain("devops.allowed_network_ranges"); + expect(questions).not.toContain('"const":"devops"'); + }, + ).converse( + knowledgeSelection(), + assistantPublicValues(draft()), + [], + language === "en" + ? "Add central Git, only from 203.0.113.0/24." + : "Zentrales Git hinzufügen, nur aus 203.0.113.0/24.", + ); + expect(result.changes).toEqual([]); + expect(result.questions.map((question) => question.path)).toEqual([ + "devops.git_flavor", + ]); + expect(result.explanation).toContain( + language === "en" ? "Nothing has been changed" : "Noch nichts geändert", + ); + }, +); diff --git a/landing-zone-configurator/app/tests/assistant-scenarios.test.ts b/landing-zone-configurator/app/tests/assistant-scenarios.test.ts index 7844a868..21bf6d3b 100644 --- a/landing-zone-configurator/app/tests/assistant-scenarios.test.ts +++ b/landing-zone-configurator/app/tests/assistant-scenarios.test.ts @@ -230,7 +230,30 @@ it.each(assistantScenarios)( expect(JSON.stringify(fixture)).not.toMatch( /af026540|lukas|preshared_key/i, ); - if (scenario.auditQuestionPaths) { + if (scenario.setupQuestionPaths) { + expect( + validateAssistantScenario(scenario, { + explanation: "Nothing changed.", + changes: [], + references: [scenario.topic], + questions: [ + { + path: scenario.setupQuestionPaths[0], + text: "Please choose.", + options: [], + }, + ], + }).failures, + ).toEqual([]); + expect( + validateAssistantScenario(scenario, { + explanation: "Nothing changed.", + changes: [], + references: [scenario.topic], + questions: [], + }).failures, + ).toContain("setup_must_ask_missing_choices_without_changes"); + } else if (scenario.auditQuestionPaths) { expect( validateAssistantScenario(scenario, { explanation: "Reviewable local draft only.", diff --git a/landing-zone-configurator/docs/assistant-knowledge/README.de.md b/landing-zone-configurator/docs/assistant-knowledge/README.de.md index ecf32be2..7c57b7d9 100644 --- a/landing-zone-configurator/docs/assistant-knowledge/README.de.md +++ b/landing-zone-configurator/docs/assistant-knowledge/README.de.md @@ -133,6 +133,26 @@ Neue Entwürfe lassen nur eine redundante Kopie des Organisationsstandards ohne ausdrücklich vorgegebene ID oder natives Scope-Feld weg. Bestehende und abweichende Scopes bleiben erhalten. +### Einrichtungsdialog und offene Entscheidungen + +Ein ausdrücklicher Einrichtungswunsch führt zu einer gezielten Rückfrage oder +einer belegten, prüfbaren Empfehlung. Enthält ein nativer Editor-Vorschlag ein +unbestätigtes Produkt, eine Adresse oder einen Kontakt, wird er vollständig +verworfen und durch eine Rückfrage zum betroffenen Feld ersetzt. Die +Quellenprüfung verhindert weiterhin die Übernahme. Andere Schema-, Geltungsbereichs-, +Zugangsdaten- und Berechtigungsfehler bleiben Fehler. Kataloggestützte Empfehlungen +sind Vorschläge, kein Berechtigungsnachweis und keine Ausführungsfreigabe. + +Neue Git-Vorschläge benötigen Größe und Zugangseinstellungen zusammen. Git-Fragen +erwarten tatsächliche Kundennetze als Freitext; eine offene Frage erlaubt keinen +öffentlichen Zugriff. Der zentrale synthetische Korpus enthält kurze deutsche und +englische Einrichtungswünsche, teilweise beantwortete Fragen und Folgeantworten, +zusätzlich zu vollständig spezifizierten Änderungen und Beratung. Die durchgängige +Journey beginnt Git mit einer Einrichtungsfrage vor der Auswahl. Simulierte +Transport- und Schutztests ergänzen diese Fälle; Feldinventar und Wissenszustellung +allein belegen keine Qualität natürlicher Dialoge. Eine übersprungene Release- +Qualifikation ist ausdrücklich kein neuer Live-Testnachweis. + ### Qualifikation mit echtem Modell Aenderungen an Servicefakten, Prompts, Wissensauswahl oder diff --git a/landing-zone-configurator/docs/assistant-knowledge/README.md b/landing-zone-configurator/docs/assistant-knowledge/README.md index 246b27af..70abbc1b 100644 --- a/landing-zone-configurator/docs/assistant-knowledge/README.md +++ b/landing-zone-configurator/docs/assistant-knowledge/README.md @@ -109,6 +109,24 @@ explicit empty list retain their native meaning. New drafts omit a redundant cop of the current organization default only when no user source pins its ID or the native scope field; existing and nondefault scopes are preserved. +### Setup dialogue and missing choices + +An explicit setup request must lead to a targeted question or a grounded, +reviewable recommendation. A native Editor proposal containing an unconfirmed +product, address or contact is discarded in full and becomes a scoped question; +source validation still prevents its acceptance. Other schema, scope, credential +and authorization failures remain errors. Catalogue-grounded recommendations +remain proposals, not proof of entitlement or execution approval. + +New Git proposals require size and access settings together. Git questions use +actual customer networks as free text; an unanswered question never authorizes +public access. The central synthetic corpus covers short English/German setup +requests, partially supplied choices and follow-ups, alongside fully specified +changes and advice. The continuous journey includes Git setup before selection. +Mocked request/guard tests complement these cases; field inventory and knowledge +delivery coverage alone do not prove natural dialogue quality. Skipped release +qualification is explicitly not a fresh live-test result. + ### Real-model qualification Changes to service facts, prompts, knowledge selection or component contracts diff --git a/landing-zone-configurator/docs/assistant-knowledge/devops-git.de.md b/landing-zone-configurator/docs/assistant-knowledge/devops-git.de.md index 270565a6..38699703 100644 --- a/landing-zone-configurator/docs/assistant-knowledge/devops-git.de.md +++ b/landing-zone-configurator/docs/assistant-knowledge/devops-git.de.md @@ -39,6 +39,14 @@ Es gibt keinen aktivierten nativen Flavor-Default: Wenn Git gewuenscht ist, aber kein ausgewaehlter/gepruefter Flavor vorliegt, `null` erklaeren und nachfragen, statt `git-10` zu erfinden. Explizite Nutzer-Flavors sind pruefbar, aber kein Verfuegbarkeitsnachweis. +Ein breiter Wunsch wie „Bitte eine zentrale Git-Instanz hinzufügen“ beginnt einen +Einrichtungsdialog und ist keine fehlerhafte Anfrage. Fehlende Größen- und +Zugangsentscheidungen erfragen; erst einen vollständigen neuen Dienst vorschlagen. +Nutzerauswahlen über Folgeantworten erhalten und nur offene Punkte erfragen. +Tatsächliche CIDRs als Freitext erfragen, ohne erfundene Beispiele oder Netzoptionen. +Eine fehlende oder leere Antwort erlaubt niemals den nativen Allow-All-Default. +Ein Katalog kann eine klar gekennzeichnete Empfehlung begründen, beweist aber +keine Berechtigung im Zielprojekt und ersetzt keine Zugangsentscheidung. Keine Runner, Integrationen, Migrationen oder Secrets ableiten. diff --git a/landing-zone-configurator/docs/assistant-knowledge/devops-git.md b/landing-zone-configurator/docs/assistant-knowledge/devops-git.md index c79dbd42..b9126839 100644 --- a/landing-zone-configurator/docs/assistant-knowledge/devops-git.md +++ b/landing-zone-configurator/docs/assistant-knowledge/devops-git.md @@ -2,46 +2,48 @@ ## Purpose -Explicit managed Git, separate from GitHub login, forks and Configurator CI. +Central managed Git, separate from GitHub login, forks and Configurator CI. ## Accelerator Contract -devops=null skips the module. The root derives project, ownership and naming, -passing git_flavor and allowed_network_ranges. git_flavor defaults to null, -NOT git-10/git-100: null creates no Git instance. An ACL-only object does not -enable Git. Root wiring, not child-module parameters alone, defines support. -Real sizes and regional availability require authorized catalogues. +Root derives project, ownership and naming; passes git_flavor and +allowed_network_ranges. devops=null skips deployment. git_flavor defaults to +null, NOT git-10/git-100: null or an ACL-only object creates no Git instance. +Live catalogues are needed for real sizes and regional availability. ## Dependencies Management/governance, identity foundations, provider rights and deliberate ACLs. -A repository fork proves neither provisioned Git nor service-account rights. +A fork proves neither provisioned Git nor service-account rights. ## Dialogue -Clarify Git need, capacity, operator and access networks. The allow-all ACL -default is NOT public-access consent. There is no enabled native flavor default: -if Git is wanted without a chosen/verified flavor, explain null and ask instead -of inventing git-10. Explicit user flavor choices are reviewable, not availability -proof. Do not infer runners, integrations, migrations or secrets. +Broad setup requests ("Please add a central git instance to the config") start +a dialogue. Ask missing size/capacity and access decisions, preserving user +answers across turns. Only propose a complete new component. There is no enabled +flavor default: ask instead of inventing git-10. A verified catalogue can ground +a labelled recommendation, never entitlement or availability. Ask actual CIDRs +as free text, without invented examples or preset networks. A blank answer never +means consent to allow all. Separate operator, runners and integrations; do not +infer migrations or secrets. ## Examples -devops=null opts out. A chosen git_flavor plus deliberate allowed_network_ranges +devops=null opts out. Selected git_flavor plus deliberate allowed_network_ranges can propose Git. git-10 illustrates syntax, not entitlement or capacity. ## Limits -Typed native Editor proposals change only the local draft on acceptance. -ACLs do not qualify backup/restore, migration, SSO or CI execution. No arbitrary -Git appliances, availability, prices or performance promises. +Editor acceptance changes only the local draft. ACLs do not qualify backup/restore, +migration, SSO or CI execution. No arbitrary Git appliances, prices, performance +or availability promises. Root wiring, not child parameters, defines support. ## Credentials -Provisioning and Git-user access are separate. No PATs, private SSH keys, Git +Provisioning and Git-user access are separate. No PATs, SSH private keys, Git passwords or CI secrets in chat; no hidden Configurator profile-ID dependency. ## Sources Root calls, DevOps variables and provider configuration in the manifest. -Refresh engine/source bindings after review; live product facts stay separate. \ No newline at end of file +Refresh source bindings after review; live product facts stay separate. diff --git a/landing-zone-configurator/docs/assistant-knowledge/manifest.json b/landing-zone-configurator/docs/assistant-knowledge/manifest.json index 35c11edf..4ca568c3 100644 --- a/landing-zone-configurator/docs/assistant-knowledge/manifest.json +++ b/landing-zone-configurator/docs/assistant-knowledge/manifest.json @@ -454,8 +454,8 @@ { "id": "devops-git", "file": "devops-git.md", - "version": 1, - "checkedOn": "2026-10-10", + "version": 2, + "checkedOn": "2026-11-17", "qualification": "local-draft-not-reviewed-release", "groups": [ "platform" @@ -471,7 +471,9 @@ "src/variables.tf", "src/modules/devops/variables.tf", "src/main.tf", - "src/providers.tf" + "src/providers.tf", + "landing-zone-configurator/app/apps/api/src/assistant/editor.ts", + "landing-zone-configurator/app/apps/api/src/assistant/model-serving.ts" ], "externalSources": [], "scenarios": [ diff --git a/landing-zone-configurator/docs/assistant-test-catalogue.json b/landing-zone-configurator/docs/assistant-test-catalogue.json index 9deb1213..c1a25567 100644 --- a/landing-zone-configurator/docs/assistant-test-catalogue.json +++ b/landing-zone-configurator/docs/assistant-test-catalogue.json @@ -2,12 +2,12 @@ "schemaVersion": 1, "status": "field-inventory-and-smoke-corpus-not-ai-qualification", "engineRevision": "a256f6896d11134fdc351786f1be5eba4e56b2e2", - "knowledgeSha256": "48967d9f510be61be627a559970720c6f8985afa9de6ef686dc7db635edb7819", + "knowledgeSha256": "214d7e81d145ea5fa6d74cbf8e174a1b9fe8b164ac37460626108582b8af0a8b", "sourceDigests": { - "scripts/assistant-scenarios.ts": "c9b2a1e618e3831b24543513be44ed7563bfd51a12540e97bda4c489eb405d03", + "scripts/assistant-scenarios.ts": "e4d6b569f36496cfe9c4c9655a18ed02a47e726e584cbd0dac7e643c8956e6df", "scripts/assistant-tests.ts": "5e19b1c74da1ffa996f2d76876cc8dc639da698d0b6f9b7e1fc6637863833a8d" }, - "suiteSha256": "b30a7161e52133f2a875758d4b20ef652ed50177a05e53009f71bad0bb930f9f", + "suiteSha256": "0a96248735604b037639f28c24e208263cbd1839996972a3322e71c73a9fce11", "topics": [ { "id": "credential-foundations", @@ -4674,6 +4674,99 @@ } ], "cases": [ + { + "id": "editor-devops-setup-en", + "message": "Please add a central git instance to the config", + "topic": "devops-git", + "fixture": "baseline", + "setupQuestionPaths": [ + "devops.git_flavor", + "devops.allowed_network_ranges" + ], + "expectedLanguage": "en", + "assertions": [ + "valid_dialogue", + "reviewed_topic_reference", + "no_changes" + ] + }, + { + "id": "editor-devops-setup-de", + "message": "Bitte eine zentrale Git-Instanz in die Konfiguration aufnehmen.", + "topic": "devops-git", + "fixture": "baseline", + "setupQuestionPaths": [ + "devops.git_flavor", + "devops.allowed_network_ranges" + ], + "expectedLanguage": "de", + "assertions": [ + "valid_dialogue", + "reviewed_topic_reference", + "no_changes" + ] + }, + { + "id": "editor-devops-size-only", + "message": "Please add central Git, using git-10. I have not chosen the access networks yet.", + "topic": "devops-git", + "fixture": "baseline", + "setupQuestionPaths": [ + "devops.allowed_network_ranges" + ], + "expectedLanguage": "en", + "assertions": [ + "valid_dialogue", + "reviewed_topic_reference", + "no_changes" + ] + }, + { + "id": "editor-devops-networks-only", + "message": "Please add central Git, accessible only from 203.0.113.0/24. I have not selected its size yet.", + "topic": "devops-git", + "fixture": "baseline", + "setupQuestionPaths": [ + "devops.git_flavor" + ], + "expectedLanguage": "en", + "assertions": [ + "valid_dialogue", + "reviewed_topic_reference", + "no_changes" + ] + }, + { + "id": "editor-devops-followup", + "topic": "devops-git", + "fixture": "baseline", + "message": "Use git-10 and allow access only from 203.0.113.0/24.", + "history": [ + { + "role": "user", + "content": "Please add a central git instance to the config" + }, + { + "role": "assistant", + "content": "Which Git size and source networks should the draft use? No choice has been made yet." + } + ], + "expectedLanguage": "en", + "editorExpected": { + "path": "devops", + "value": { + "git_flavor": "git-10", + "allowed_network_ranges": [ + "203.0.113.0/24" + ] + } + }, + "assertions": [ + "valid_dialogue", + "reviewed_topic_reference", + "no_changes" + ] + }, { "id": "editor-devops", "topic": "devops-git",