From b48b043d56d97c59b5c3deae1753aa190eac60b5 Mon Sep 17 00:00:00 2001 From: martinezmo Date: Wed, 11 Nov 2026 13:09:27 +0100 Subject: [PATCH 1/8] fix(registry): allow hard delete when error status --- services/registry/v1api/wait/wait.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/services/registry/v1api/wait/wait.go b/services/registry/v1api/wait/wait.go index d24ea56651..074b4277a3 100644 --- a/services/registry/v1api/wait/wait.go +++ b/services/registry/v1api/wait/wait.go @@ -46,12 +46,16 @@ func UpdateArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, pr } // DeleteArtifactoryWaitHandler will wait for the artifactory to be deleted. +// It will wait when the current state either is +// 1. ARTIFACTORYSTATE_ACTIVE -> Performing a soft delete +// 2. ARTIFACTORYSTATE_ERROR -> Performing a hard delete +// It will wait until a 404 is returned. func DeleteArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, projectId, regionId, artifactoryId string) *wait.AsyncActionHandler[registry.Artifactory] { waitConfig := wait.WaiterHelper[registry.Artifactory, registry.ArtifactoryState]{ FetchInstance: a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute, GetState: getStateArtifactory, - ActiveState: nil, - ErrorState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ERROR}, + ActiveState: []registry.ArtifactoryState{}, + ErrorState: nil, DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, } From f00a71dc40c525552c3fc1a0187a31431350872f Mon Sep 17 00:00:00 2001 From: martinezmo Date: Wed, 11 Nov 2026 13:23:48 +0100 Subject: [PATCH 2/8] fix(registry): version to hard delete error proxy --- CHANGELOG.md | 3 +++ services/registry/CHANGELOG.md | 4 ++++ services/registry/VERSION | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 831cb43204..b62d796a69 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -248,6 +248,9 @@ - `v2api`: - **Breaking Change:** Removed `rabbitmq_tracing` enum value from `InstanceParametersPluginsInner` - `registry`: + - [v0.2.1](services/registry/CHANGELOG.md#v021) + - `v1api`: + - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` to allow hard delete on ERROR state - [v0.2.0](services/registry/CHANGELOG.md#v020) - `v1api`: - **Feature:** Add `ErrorDescription` field to `Artifactory` which describes the reason for the error state diff --git a/services/registry/CHANGELOG.md b/services/registry/CHANGELOG.md index 90f1fd7a59..7e78487a86 100644 --- a/services/registry/CHANGELOG.md +++ b/services/registry/CHANGELOG.md @@ -1,3 +1,7 @@ + +## v0.2.1 +- **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` to allow hard delete on ERROR state + ## v0.2.0 - `v1api`: - **Feature:** Add `ErrorDescription` field to `Artifactory` which describes the reason for the error state diff --git a/services/registry/VERSION b/services/registry/VERSION index 81fd7ba087..eac0a1441d 100644 --- a/services/registry/VERSION +++ b/services/registry/VERSION @@ -1 +1 @@ -v0.2.0 \ No newline at end of file +v0.2.1 \ No newline at end of file From 7becd6bc6f887cb5b22074d9765b69e4feb26c61 Mon Sep 17 00:00:00 2001 From: martinezmo Date: Wed, 11 Nov 2026 13:29:48 +0100 Subject: [PATCH 3/8] fix(registry): adjust some changelog identation --- CHANGELOG.md | 3 +-- services/registry/CHANGELOG.md | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b62d796a69..8b203e41b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -249,8 +249,7 @@ - **Breaking Change:** Removed `rabbitmq_tracing` enum value from `InstanceParametersPluginsInner` - `registry`: - [v0.2.1](services/registry/CHANGELOG.md#v021) - - `v1api`: - - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` to allow hard delete on ERROR state + - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` allow hard delete on ERROR state - [v0.2.0](services/registry/CHANGELOG.md#v020) - `v1api`: - **Feature:** Add `ErrorDescription` field to `Artifactory` which describes the reason for the error state diff --git a/services/registry/CHANGELOG.md b/services/registry/CHANGELOG.md index 7e78487a86..14f7712588 100644 --- a/services/registry/CHANGELOG.md +++ b/services/registry/CHANGELOG.md @@ -1,6 +1,6 @@ ## v0.2.1 -- **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` to allow hard delete on ERROR state +- **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` allow hard delete on ERROR state ## v0.2.0 - `v1api`: From f8cd7a0d60fe3b7f515edafed7813681fb942809 Mon Sep 17 00:00:00 2001 From: martinezmo Date: Wed, 11 Nov 2026 14:29:05 +0100 Subject: [PATCH 4/8] fix(registry): fix soft and hard delete wait handler --- services/registry/v1api/wait/wait.go | 64 ++++++++++++++++++----- services/registry/v1api/wait/wait_test.go | 29 ++++++++-- 2 files changed, 76 insertions(+), 17 deletions(-) diff --git a/services/registry/v1api/wait/wait.go b/services/registry/v1api/wait/wait.go index 074b4277a3..ca20afdd2f 100644 --- a/services/registry/v1api/wait/wait.go +++ b/services/registry/v1api/wait/wait.go @@ -3,9 +3,11 @@ package wait import ( "context" "errors" + "fmt" "net/http" "time" + "github.com/stackitcloud/stackit-sdk-go/core/oapierror" "github.com/stackitcloud/stackit-sdk-go/core/wait" registry "github.com/stackitcloud/stackit-sdk-go/services/registry/v1api" ) @@ -46,20 +48,58 @@ func UpdateArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, pr } // DeleteArtifactoryWaitHandler will wait for the artifactory to be deleted. -// It will wait when the current state either is -// 1. ARTIFACTORYSTATE_ACTIVE -> Performing a soft delete -// 2. ARTIFACTORYSTATE_ERROR -> Performing a hard delete -// It will wait until a 404 is returned. +// It supports two deletion flows based on the initial state: +// 1. Soft delete (initial status is Active): waits through Active/Reconciling until state is Deleted. +// 2. Hard delete (initial status is Error): waits through Error/Reconciling until the resource is removed (HTTP 404). func DeleteArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, projectId, regionId, artifactoryId string) *wait.AsyncActionHandler[registry.Artifactory] { - waitConfig := wait.WaiterHelper[registry.Artifactory, registry.ArtifactoryState]{ - FetchInstance: a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute, - GetState: getStateArtifactory, - ActiveState: []registry.ArtifactoryState{}, - ErrorState: nil, - DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, - } + var initialChecked bool + var isHardDelete bool + + handler := wait.New(func() (waitFinished bool, response *registry.Artifactory, err error) { + instance, err := a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute() + if err != nil { + var oapiErr *oapierror.GenericOpenAPIError + if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound { + return true, nil, nil + } + return false, nil, err + } + + state, err := getStateArtifactory(instance) + if err != nil { + return false, nil, err + } + + if !initialChecked { + initialChecked = true + switch state { + case registry.ARTIFACTORYSTATE_ERROR: + isHardDelete = true + case registry.ARTIFACTORYSTATE_ACTIVE, registry.ARTIFACTORYSTATE_RECONCILING: + isHardDelete = false + case registry.ARTIFACTORYSTATE_DELETED: + return true, instance, nil + default: + return true, instance, fmt.Errorf("cannot wait for delete: artifactory is in invalid initial state %v", state) + } + } + + if isHardDelete { + return false, nil, nil + } + + switch state { + case registry.ARTIFACTORYSTATE_DELETED: + return true, instance, nil + case registry.ARTIFACTORYSTATE_ACTIVE, registry.ARTIFACTORYSTATE_RECONCILING: + return false, nil, nil + case registry.ARTIFACTORYSTATE_ERROR: + return true, instance, fmt.Errorf("artifactory soft deletion failed: state is %v", state) + default: + return false, nil, nil + } + }) - handler := wait.New(waitConfig.Wait()) handler.SetTimeout(5 * time.Minute) return handler } diff --git a/services/registry/v1api/wait/wait_test.go b/services/registry/v1api/wait/wait_test.go index 179f7c2b6c..2c92ff69d9 100644 --- a/services/registry/v1api/wait/wait_test.go +++ b/services/registry/v1api/wait/wait_test.go @@ -186,26 +186,45 @@ func TestDeleteArtifactoryWaitHandler(t *testing.T) { wantErr bool }{ { - name: "success immediately on 404", + name: "soft delete: success delayed after active and reconciling", responses: []response{ - {status: http.StatusNotFound}, + {state: ArtifactoryActive}, + {state: ArtifactoryReconciling}, + {state: ArtifactoryDeleted}, + }, + wantErr: false, + }, + { + name: "soft delete: success immediately when already deleted", + responses: []response{ + {state: ArtifactoryDeleted}, }, wantErr: false, }, { - name: "success delayed after reconciling", + name: "soft delete: failure when transitioning to error", responses: []response{ + {state: ArtifactoryActive}, {state: ArtifactoryReconciling}, + {state: ArtifactoryError}, + }, + wantErr: true, + }, + { + name: "hard delete: success immediately on 404", + responses: []response{ {status: http.StatusNotFound}, }, wantErr: false, }, { - name: "error state", + name: "hard delete: success delayed from error to 404", responses: []response{ {state: ArtifactoryError}, + {state: ArtifactoryReconciling}, + {status: http.StatusNotFound}, }, - wantErr: true, + wantErr: false, }, { name: "api error", From 561272c2d7031dd86ae1cb5e8d7bcbf2e94ea9fc Mon Sep 17 00:00:00 2001 From: martinezmo Date: Thu, 12 Nov 2026 14:35:59 +0100 Subject: [PATCH 5/8] fix(registry): add harbor error info when creating artifactory --- services/registry/v1api/wait/wait.go | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/services/registry/v1api/wait/wait.go b/services/registry/v1api/wait/wait.go index ca20afdd2f..84dd5662a7 100644 --- a/services/registry/v1api/wait/wait.go +++ b/services/registry/v1api/wait/wait.go @@ -23,7 +23,18 @@ const ( func CreateArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, projectId, regionId, artifactoryId string) *wait.AsyncActionHandler[registry.Artifactory] { waitConfig := wait.WaiterHelper[registry.Artifactory, registry.ArtifactoryState]{ FetchInstance: a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute, - GetState: getStateArtifactory, + GetState: func(artifactory *registry.Artifactory) (registry.ArtifactoryState, error) { + state, err := getStateArtifactory(artifactory) + if err != nil { + return "", err + } + if state == registry.ARTIFACTORYSTATE_ERROR { + if artifactory.ErrorDescription != nil && *artifactory.ErrorDescription != "" { + return state, fmt.Errorf("artifactory creation failed: %s", *artifactory.ErrorDescription) + } + } + return state, nil + }, ActiveState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ACTIVE}, ErrorState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ERROR}, } From dde59ef1b719610fb9c35843cae841a48bbfa0da Mon Sep 17 00:00:00 2001 From: martinezmo Date: Thu, 12 Nov 2026 14:50:24 +0100 Subject: [PATCH 6/8] fix(registry): go fmt error in wait.go --- services/registry/v1api/wait/wait.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/registry/v1api/wait/wait.go b/services/registry/v1api/wait/wait.go index 84dd5662a7..bee4df7346 100644 --- a/services/registry/v1api/wait/wait.go +++ b/services/registry/v1api/wait/wait.go @@ -35,8 +35,8 @@ func CreateArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, pr } return state, nil }, - ActiveState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ACTIVE}, - ErrorState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ERROR}, + ActiveState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ACTIVE}, + ErrorState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ERROR}, } handler := wait.New(waitConfig.Wait()) From a8fdd1f45fbaa7e26942d1498c09f2a1717be94a Mon Sep 17 00:00:00 2001 From: martinezmo Date: Mon, 16 Nov 2026 11:38:58 +0100 Subject: [PATCH 7/8] fix(registry): clarify flows --- CHANGELOG.md | 8 +- services/registry/v1api/wait/wait.go | 111 +++++++++------------- services/registry/v1api/wait/wait_test.go | 94 ++++++++++++++---- 3 files changed, 123 insertions(+), 90 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c32d5a0ded..9d6dde87b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## Release (2026-MM-DD) + +- `registry`: + - [v0.2.1](services/registry/CHANGELOG.md#v021) + - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` allow hard delete on ERROR state + ## Release (2026-11-11) - `alb`: @@ -248,8 +254,6 @@ - `v2api`: - **Breaking Change:** Removed `rabbitmq_tracing` enum value from `InstanceParametersPluginsInner` - `registry`: - - [v0.2.1](services/registry/CHANGELOG.md#v021) - - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` allow hard delete on ERROR state - [v0.2.0](services/registry/CHANGELOG.md#v020) - `v1api`: - **Feature:** Add `ErrorDescription` field to `Artifactory` which describes the reason for the error state diff --git a/services/registry/v1api/wait/wait.go b/services/registry/v1api/wait/wait.go index bee4df7346..de85d5202a 100644 --- a/services/registry/v1api/wait/wait.go +++ b/services/registry/v1api/wait/wait.go @@ -7,7 +7,6 @@ import ( "net/http" "time" - "github.com/stackitcloud/stackit-sdk-go/core/oapierror" "github.com/stackitcloud/stackit-sdk-go/core/wait" registry "github.com/stackitcloud/stackit-sdk-go/services/registry/v1api" ) @@ -15,28 +14,17 @@ import ( const ( ArtifactoryReconciling = registry.ARTIFACTORYSTATE_RECONCILING ArtifactoryActive = registry.ARTIFACTORYSTATE_ACTIVE - ArtifactoryDeleted = registry.ARTIFACTORYSTATE_DELETED ArtifactoryError = registry.ARTIFACTORYSTATE_ERROR ) // CreateArtifactoryWaitHandler will wait for the artifactory to be created/ready. +// If there is an error state, it will return the error immediately. func CreateArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, projectId, regionId, artifactoryId string) *wait.AsyncActionHandler[registry.Artifactory] { waitConfig := wait.WaiterHelper[registry.Artifactory, registry.ArtifactoryState]{ FetchInstance: a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute, - GetState: func(artifactory *registry.Artifactory) (registry.ArtifactoryState, error) { - state, err := getStateArtifactory(artifactory) - if err != nil { - return "", err - } - if state == registry.ARTIFACTORYSTATE_ERROR { - if artifactory.ErrorDescription != nil && *artifactory.ErrorDescription != "" { - return state, fmt.Errorf("artifactory creation failed: %s", *artifactory.ErrorDescription) - } - } - return state, nil - }, - ActiveState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ACTIVE}, - ErrorState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ERROR}, + GetState: getStateArtifactory, + ActiveState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ACTIVE}, + ErrorState: []registry.ArtifactoryState{registry.ARTIFACTORYSTATE_ERROR}, } handler := wait.New(waitConfig.Wait()) @@ -59,65 +47,54 @@ func UpdateArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, pr } // DeleteArtifactoryWaitHandler will wait for the artifactory to be deleted. -// It supports two deletion flows based on the initial state: -// 1. Soft delete (initial status is Active): waits through Active/Reconciling until state is Deleted. -// 2. Hard delete (initial status is Error): waits through Error/Reconciling until the resource is removed (HTTP 404). +// +// The API provides a single delete call, but the internal deletion behavior +// depends on the status of the backend custom resource (CR) when delete is called: +// 1. Soft delete (CR is in Active state): +// Active -> Reconciling -> HTTP 404 (Not Found). +// The artifactory is soft-deleted; the API returns HTTP 404 (Not Found), +// even though the underlying custom resource still remains internally. +// 2. Hard delete (CR is in Error state): +// Error -> HTTP 404 (Not Found). +// The custom resource is permanently purged without transitioning through Reconciling. +// +// In both flows, the wait handler polls until GetArtifactory returns HTTP 404 (Not Found). func DeleteArtifactoryWaitHandler(ctx context.Context, a registry.DefaultAPI, projectId, regionId, artifactoryId string) *wait.AsyncActionHandler[registry.Artifactory] { - var initialChecked bool - var isHardDelete bool - - handler := wait.New(func() (waitFinished bool, response *registry.Artifactory, err error) { - instance, err := a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute() - if err != nil { - var oapiErr *oapierror.GenericOpenAPIError - if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound { - return true, nil, nil - } - return false, nil, err - } - - state, err := getStateArtifactory(instance) - if err != nil { - return false, nil, err - } - - if !initialChecked { - initialChecked = true - switch state { - case registry.ARTIFACTORYSTATE_ERROR: - isHardDelete = true - case registry.ARTIFACTORYSTATE_ACTIVE, registry.ARTIFACTORYSTATE_RECONCILING: - isHardDelete = false - case registry.ARTIFACTORYSTATE_DELETED: - return true, instance, nil - default: - return true, instance, fmt.Errorf("cannot wait for delete: artifactory is in invalid initial state %v", state) - } - } - - if isHardDelete { - return false, nil, nil - } - - switch state { - case registry.ARTIFACTORYSTATE_DELETED: - return true, instance, nil - case registry.ARTIFACTORYSTATE_ACTIVE, registry.ARTIFACTORYSTATE_RECONCILING: - return false, nil, nil - case registry.ARTIFACTORYSTATE_ERROR: - return true, instance, fmt.Errorf("artifactory soft deletion failed: state is %v", state) - default: - return false, nil, nil - } - }) + waitConfig := wait.WaiterHelper[registry.Artifactory, registry.ArtifactoryState]{ + FetchInstance: a.GetArtifactory(ctx, projectId, regionId, artifactoryId).Execute, + GetState: getStateArtifactoryDelete, + ActiveState: []registry.ArtifactoryState{}, + ErrorState: nil, + DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, + } + handler := wait.New(waitConfig.Wait()) handler.SetTimeout(5 * time.Minute) return handler } +// For insert and update the error state is an error and the error is enriched with the information got from the container registry API. func getStateArtifactory(response *registry.Artifactory) (registry.ArtifactoryState, error) { if response == nil { return "", errors.New("empty response") } - return response.GetState(), nil + + state := response.GetState() + // If the state is error, enrich the description with the information got from the container registry API + if state == registry.ARTIFACTORYSTATE_ERROR { + if response.ErrorDescription != nil && *response.ErrorDescription != "" { + return state, fmt.Errorf("%s", *response.ErrorDescription) + } + } + return state, nil +} + +// Special case of getState, in delete action the error state is not an error itself but a normal state. +func getStateArtifactoryDelete(response *registry.Artifactory) (registry.ArtifactoryState, error) { + if response == nil { + return "", errors.New("empty response") + } + + state := response.GetState() + return state, nil } diff --git a/services/registry/v1api/wait/wait_test.go b/services/registry/v1api/wait/wait_test.go index 2c92ff69d9..6d30546e6c 100644 --- a/services/registry/v1api/wait/wait_test.go +++ b/services/registry/v1api/wait/wait_test.go @@ -186,42 +186,25 @@ func TestDeleteArtifactoryWaitHandler(t *testing.T) { wantErr bool }{ { - name: "soft delete: success delayed after active and reconciling", + name: "success immediately on 404", responses: []response{ - {state: ArtifactoryActive}, - {state: ArtifactoryReconciling}, - {state: ArtifactoryDeleted}, - }, - wantErr: false, - }, - { - name: "soft delete: success immediately when already deleted", - responses: []response{ - {state: ArtifactoryDeleted}, + {status: http.StatusNotFound}, }, wantErr: false, }, { - name: "soft delete: failure when transitioning to error", + name: "soft delete: success delayed after active and reconciling", responses: []response{ {state: ArtifactoryActive}, {state: ArtifactoryReconciling}, - {state: ArtifactoryError}, - }, - wantErr: true, - }, - { - name: "hard delete: success immediately on 404", - responses: []response{ {status: http.StatusNotFound}, }, wantErr: false, }, { - name: "hard delete: success delayed from error to 404", + name: "hard delete: success delayed after error", responses: []response{ {state: ArtifactoryError}, - {state: ArtifactoryReconciling}, {status: http.StatusNotFound}, }, wantErr: false, @@ -272,6 +255,32 @@ func TestGetStateArtifactory(t *testing.T) { want: ArtifactoryActive, wantErr: false, }, + { + name: "error state with description", + resp: ®istry.Artifactory{ + State: ArtifactoryError, + ErrorDescription: utils.Ptr("provisioning failed"), + }, + want: ArtifactoryError, + wantErr: true, + }, + { + name: "error state with empty description", + resp: ®istry.Artifactory{ + State: ArtifactoryError, + ErrorDescription: utils.Ptr(""), + }, + want: ArtifactoryError, + wantErr: false, + }, + { + name: "error state without description", + resp: ®istry.Artifactory{ + State: ArtifactoryError, + }, + want: ArtifactoryError, + wantErr: false, + }, } for _, tt := range tests { @@ -286,3 +295,46 @@ func TestGetStateArtifactory(t *testing.T) { }) } } + +func TestGetStateArtifactoryDelete(t *testing.T) { + tests := []struct { + name string + resp *registry.Artifactory + want registry.ArtifactoryState + wantErr bool + }{ + { + name: "nil response", + resp: nil, + wantErr: true, + }, + { + name: "valid state", + resp: ®istry.Artifactory{ + State: ArtifactoryActive, + }, + want: ArtifactoryActive, + wantErr: false, + }, + { + name: "error state", + resp: ®istry.Artifactory{ + State: ArtifactoryError, + }, + want: ArtifactoryError, + wantErr: false, + }, + } + + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + got, err := getStateArtifactoryDelete(tt.resp) + if (err != nil) != tt.wantErr { + t.Fatalf("getStateArtifactoryDelete() error = %v, wantErr %v", err, tt.wantErr) + } + if got != tt.want { + t.Fatalf("getStateArtifactoryDelete() = %v, want %v", got, tt.want) + } + }) + } +} From 8ef5dcc28b24007bd3cde8e357374a6aa0f71982 Mon Sep 17 00:00:00 2001 From: martinezmo Date: Mon, 16 Nov 2026 12:05:47 +0100 Subject: [PATCH 8/8] fix(registry): fix format and features in CHANGELOG.md --- CHANGELOG.md | 1 + services/registry/CHANGELOG.md | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9d6dde87b8..2bd7a4d1df 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ - `registry`: - [v0.2.1](services/registry/CHANGELOG.md#v021) - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` allow hard delete on ERROR state + - **Feature:** Add `ErrorDescription` information to `CreateArtifactoryWaitHandler` and `UpdateArtifactoryWaitHandler` ## Release (2026-11-11) diff --git a/services/registry/CHANGELOG.md b/services/registry/CHANGELOG.md index 14f7712588..d5d0c61d52 100644 --- a/services/registry/CHANGELOG.md +++ b/services/registry/CHANGELOG.md @@ -1,6 +1,6 @@ - ## v0.2.1 - **Bugfix:** Waiter `DeleteArtifactoryWaitHandler` allow hard delete on ERROR state +- **Feature:** Add `ErrorDescription` information to `CreateArtifactoryWaitHandler` and `UpdateArtifactoryWaitHandler` ## v0.2.0 - `v1api`: @@ -8,4 +8,4 @@ ## v0.1.0 - **New:** SDK module for STACKIT Container Registry service. -- `v1`: New package which can be used for communication with the registry v1 API \ No newline at end of file +- `v1`: New package which can be used for communication with the registry v1 API