Repository navigation
feat(agent-question): the React UI's bundle committed and served at the root; the vanilla page retired - #76
Merged
Conversation
…he root; the vanilla page retired RFC-0014 round 4, section 21.4; build plan step 11. The front-end is built in the Node.js pack (mercury-nodejs extensions/agent-question-ui) and its bundle deployed into extensions/agent-question/resources/public, which the host's static content service serves at / from the same origin - no CORS, nothing configured. GET /questions/app and the generated page are gone; the engines' actuator endpoints stay at their paths beside the bundle for Kubernetes probes and operations, and the UI offers them as a menu; the test checks the committed bundle and the five endpoints are served. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Co-Authored-By: Claude Fable 5.1 <[email protected]>
… when the application stops; the bundle rebuilt Found by the live drive of the React UI (mercury-composable docs/test-reports/agent-question-ui-live-drive.md): a device holding the agent-question stream kept a stopping backend alive - after SIGTERM the host stopped listening within two seconds but aiohttp waited for the stream, which never ends on its own, and the process was still there 75 seconds later; in a container, the grace period and a SIGKILL. Platform.on_shutdown maps to aiohttp's on_shutdown: the moment the application starts to stop, before the host waits for the requests in flight; the agent-question app ends every device's stream there (close_streams) and the devices reconnect to the next instance from their last sequence. Re-driven: the process gone within a second of SIGTERM, the device connected again three seconds after the restart. The bundle rebuilt in the Node.js pack (the card order within a case, mark all notices as seen) and recommitted here. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Co-Authored-By: Claude Fable 5.1 <[email protected]>
acn-ericlaw
added a commit
that referenced
this pull request
Nov 20, 2026
…print closed Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extensions/agent-question/resources/public(RFC-0014 round 4, section 21.4; build plan step 11), built in the Node.js pack (mercury-nodejsextensions/agent-question-ui, feat(agent-question-ui): the React UI - the one front-end of the agent-question app, with an actuator menu mercury-nodejs#141) and deployed here by its release script; the host's static content service serves it at/from the same origin - no CORS, nothing configured.GET /questions/appand the generated page are gone fromagent_question.py; the engines' actuator endpoints (/info,/info/routes,/health,/env,/livenessprobe) stay at their paths beside the bundle and the UI offers them as a menu./, the hashed script and stylesheet,/favicon.svg) and the five actuator endpoints are served; README; CHANGELOG Added 9, Changed 4. ruff clean, basedpyright 0, 775 passed / 76 skipped.Why
One front-end to maintain in one place for both packs' backends (Eric, 2026-11-19), served from each backend's own origin. The actuator endpoints are preserved because a container manager's probes depend on them in the cloud (Eric, 2026-11-20). A change to the UI is a build in the Node.js pack and a commit of the bundle here.
Also in this PR - from the live drive (2026-11-20)
Platform.on_shutdown(callback)(CHANGELOG Added 10): aiohttp'son_shutdown- the moment the application starts to stop, while the host still holds its connections and before it waits for the requests in flight. The drive found that a device holding the agent-question stream kept a stopping backend alive: after SIGTERM the host stopped listening within two seconds but waited for the stream, which never ends on its own, and the process was still there 75 seconds later - in a container, the grace period and a SIGKILL. The app now ends every device's stream in that hook (close_streams); re-driven, the process was gone within a second and the device reconnected three seconds after the restart, nothing missed. Tested: a stream ends on the hook, a stream opened while stopping ends at once,_attachregisters the hook. The Node.js twin isPlatform.onShutdown(mercury-nodejs #141).seenstate with Mark all notices as seen).docs/test-reports/agent-question-ui-live-drive.mdin mercury-composable (PR to follow).🤖 Generated with Claude Code