Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; the approved file list now stays fixed while the dialog is open. SummaryAdds confirmation before Replace All and keeps the approved files and search settings unchanged while the dialog is open.
Reviews (2) · Last reviewed commit: "fix(search): only replace files that wer..." · Reviewed by Greptile |
results kept coming in while the dialog was open, so replace all could touch files that weren't in the count
youssefm1
force-pushed
the
confirm-replace-all
branch
from
November 13, 2026 02:30
f1db4fa to
9229ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3045
Replace All in Search in files now shows a confirm dialog first, e.g. "Replace 12 matches in 3 files?". If you cancel, nothing changes and the running search isn't stopped.
replace all confirmstring to all lang files (English text for now) and toindex.d.tsI haven't built the APK for this one, so I couldn't try it on a device yet.