Skip to content

feat(search): ask for confirmation before replace all - #3051

Open
youssefm1 wants to merge 2 commits into
Acode-Foundation:mainfrom
youssefm1:confirm-replace-all
Open

youssefm1 wants to merge 2 commits into
Acode-Foundation:mainfrom
youssefm1:confirm-replace-all

Conversation

@youssefm1

Copy link
Copy Markdown

Closes #3045

Replace All in Search in files now shows a confirm dialog first, e.g. "Replace 12 matches in 3 files?". If you cancel, nothing changes and the running search isn't stopped.

  • added the replace all confirm string to all lang files (English text for now) and to index.d.ts
  • the dialog only shows when there are results, otherwise replaceAll behaves like before

I haven't built the APK for this one, so I couldn't try it on a device yet.

@github-actions github-actions Bot added the translations Anything related to Translations Whether a Issue or PR label Nov 12, 2026
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the approved file list now stays fixed while the dialog is open.

Summary

Adds confirmation before Replace All and keeps the approved files and search settings unchanged while the dialog is open.

  • Replace All shows a confirmation before changing files.

Reviews (2) · Last reviewed commit: "fix(search): only replace files that wer..." · Reviewed by Greptile

Comment thread src/sidebarApps/searchInFiles/index.js Resolved
results kept coming in while the dialog was open, so replace all could touch files that weren't in the count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Anything related to Translations Whether a Issue or PR

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Search in files: confirm before replace-all

1 participant