Repository navigation
fix: upgrade zip to 9.5.0 and flag zip cloaking - #5
Merged
Merged
Conversation
zip 2.4.2 has open advisories, including the critical "zip cloaking" parser differential, where local file headers and the central directory describe different files. - Upgrade zip to 9.5.0 with only pure-Rust deflate (zlib-rs), pinned exactly because the reader uses `zip::unstable::read::ZipIterable`. - Read entries with `ZipIterable`, which walks the central directory in order and keeps duplicate names like JSZip. zip 9's `ZipArchive` indexes entries by name and drops duplicates, which would hide the copy Acode installs. - New `archive.header_mismatch` (High): a separate pass validates every local header against the central directory, so a cloaked zip needs review while the installed files are still scanned. - Decode entry names as UTF-8 like JSZip instead of falling back to CP437. - Add raw-zip tests for exact duplicate names and cloaked headers. - Bump rules version to 2026.11.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
zipfrom 2.4.2 to 9.5.0, which fixes the three Dependabot advisories (zip cloaking, symlink-target handling, AES HMAC bypass).Added
archive.header_mismatch(High): flags local file headers that disagree with the central directory ("zip cloaking"). The files Acode installs are still scanned.ZipIterable, so every copy of a duplicate name is kept and the last one wins, matching JSZip. zip 9'sZipArchivewould drop duplicates.