Repository navigation
Join a headless run's late accounting before it returns, and isolate the shared team fixtures - #2604
Merged
Merged
Conversation
Give sharing fixtures their own paired home before custody saves, preserving explicit solo delivery and device cursor assertions.
Track leaf receipt settlement in the existing background wait, retain its ledger path, and close usage writers after command producers stop. Preserve the existing stop bounds and cover the real timeout door.
The manual page for adaptive runs states the usage-writer close every run gets and the bound it works within; the change entry records what was true before and what is true now. Co-Authored-By: Claude Fable 5.2 <[email protected]>
Co-Authored-By: Claude Fable 5.2 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev's gate went red on six tests after #2597. This fixes five of them at the cause.
What was wrong
codeaf docould return while cancelled-call accounting was still writing. A run that timed out returned before the receipt settlement for its cancelled calls had created its usage writer, so a write could land under the run's home after the command had returned.TestARefusedRunThatWroteNothingNamesTheDirectoryandTestATimeoutAfterWritingKeepsTheFileInTheJSONEndingcaught it as a temp-folder cleanup failure. Recover usage rows after a crash without changing charges #2387 widened the window by routing that write through the durable journal and its retry.internal/sessionteam tests read a solo identity an earlier test had saved.TestMixedTeamRecipientsWriteOnceAndNameThoseNotReached,TestPacketDecideAndEscalateRefuseRemoteDestinationsBeforeMutationandTestRemoteTeamSendsStartsPostsAndRousesRefuseBeforeTrafficpassed alone and failed in a full package run, on either tree, once the agentdid: add encrypted custody, purpose-bound signing and v1 identity documents #2090 custody save ran first.What changed
codeaf docloses the process usage writers after its workers stop, under the existing two-second usage close bound. Each leaf keeps the ledger path it was built with. No bound was raised.doandexecwait for at shutdown.Validation contract
codeaf dorun that times out writes nothing under its home after it returns, when the provider and disk respond within the existing bounds.Not fixed here
TestStopCutPairsToolsAndAcceptsNextTurn/between_calls=falsefailed once on CI and did not reproduce in 30 isolated runs or in five runs of its CI shard, so it is left unchanged.Checked
make test-quick, plus Linux and Windows vet.dotests 30 times beside their neighbours and with four copies at once; the session shards that held the three team tests, five times each.codeaf execandcodeaf dorun, and a timed quit.🤖 Generated with Claude Code