Skip to content

fix BC jump offset for NonUniformMuInteractionSampler - #16158

Merged
sawenzel merged 1 commit into
AliceO2Group:devfrom
ehellbar:pr16158
Nov 21, 2026
Merged

sawenzel merged 1 commit into
AliceO2Group:devfrom
ehellbar:pr16158

Conversation

@ehellbar

@ehellbar ehellbar commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

this is a tentative fix for https://its.cern.ch/jira/browse/O2-7330

The problem seems to be that the same BC can be sampled multiple times because getBCJump() can return 0, increasing the in-bunch pile-up to unphysical values. I will post more details on this in the JIRA ticket soon.

This fix still needs to be confirmed with a local reproducer!

@ehellbar
ehellbar requested a review from sawenzel as a code owner November 19, 2026 14:19
@ehellbar

ehellbar commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

details now in https://its.cern.ch/jira/browse/O2-7330?focusedId=7509632&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-7509632. With the fix, the fraction of BCs with one and multiple collisions using the non-trivial mu distribution sampling is in agreement with the poisson expectation and the uniform sampling (=not using the non-trivial mu distribution), while without this fix, the fraction of BC with >=2 collisions was a factor >2 larger than the poisson expectation.

These number were obtained from 10 TFs of a OO GP MC reproducer.

@sawenzel sawenzel added the bug label Nov 21, 2026
@sawenzel
sawenzel merged commit 840a084 into AliceO2Group:dev Nov 21, 2026
13 checks passed
sawenzel added a commit that referenced this pull request Nov 21, 2026
This adds two unit tests for the non-uniform interaction sampler that need no GRID access.

- With uniform scales, the fraction of occupied crossings with two or more collisions must match Poisson.
- With alternating scales, each colliding BC must follow Poisson at its own mu.
- Both tests fail without the BC jump fix from #16158, with 26 % instead of 9.7 % multi-collision crossings at mu = 0.2.

https://its.cern.ch/jira/browse/O2-7330

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants