Skip to content

Stop anchorMC when the reco workflow printout is missing - #2561

Merged
sawenzel merged 2 commits into
AliceO2Group:masterfrom
sawenzel:anchormc-check-workflowconfig
Nov 21, 2026
Merged

sawenzel merged 2 commits into
AliceO2Group:masterfrom
sawenzel:anchormc-check-workflowconfig

Conversation

@sawenzel

Copy link
Copy Markdown
Contributor

This adds a check that workflowconfig.log contains the printed reco workflow of every step.

  • If the printout was lost, config-json.json was created with empty ConfigParams and passed the existing check.
  • The MC then ran the reconstruction without the anchored settings, for example ITS cluster squashing off.
  • Existing reco tags keep the O2 script that can lose the printout, so the check is needed independently of an O2 fix.
  • The check is added to anchorMC.sh and anchorMC_DataEmbedding.sh.

https://its.cern.ch/jira/browse/O2-7359

The O2 side is fixed in AliceO2Group/AliceO2#16169

This adds a check that workflowconfig.log contains the printed reco workflow of every step.

- If the printout was lost, config-json.json was created with empty ConfigParams and passed the existing check.
- The MC then ran the reconstruction without the anchored settings, for example ITS cluster squashing off.
- Existing reco tags keep the O2 script that can lose the printout, so the check is needed independently of an O2 fix.
- The check is added to anchorMC.sh and anchorMC_DataEmbedding.sh.

https://its.cern.ch/jira/browse/O2-7359

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel
sawenzel requested a review from jackal1-66 as a code owner November 21, 2026 14:04
This extends the workflowconfig.log check to printouts that were cut off part-way.

- Such jobs kept the anchored settings only for the first executables of the reco workflow.
- The check now also requires the final o2-dpl-run line for every step.

https://its.cern.ch/jira/browse/O2-7359

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@sawenzel
sawenzel merged commit 57000ab into AliceO2Group:master Nov 21, 2026
10 checks passed
@sawenzel
sawenzel deleted the anchormc-check-workflowconfig branch November 21, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant