Repository navigation
fix(pi): bump hono and @hono/node-server overrides to clear audit gate - #333
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Resolve the integrations/pi/package.json overrides conflict in favour of the patched hono 4.13.18 and @hono/node-server 2.1.8 floors that npm-shrinkwrap.json already resolves, so the lock and the declared overrides agree. Also close the two remaining coverage gaps around those overrides: - tests/test_release_infrastructure.py: assert the hono and @hono/node-server overrides and their locked version floors alongside the other pinned leaves. - integrations/pi/README.md: describe the hono and @hono/node-server leaves together with undici and minimatch. Verified: pytest tests/test_release_infrastructure.py tests/test_dashboard_vendor_assets.py, ruff check on the edited test, and in integrations/pi `npm run verify` plus `npm audit --omit=dev` (0 vulnerabilities).
|
Checked the override bump and the shrinkwrap diff. Keeping lockfileVersion 3 while limiting the change to hono and @hono/node-server is the right scope. One verification note worth adding: run the audit from a clean |
Merge origin/main and strengthen transitive override floor assertions across nested shrinkwrap entries.
|
2-agent review & optimization status ( Merge-gate blocker requiring operator action:
|
…et suites (#336) ### Summary - Add a persistent `worker_threads` Node broker (`tests/_node_runner.py`, `tests/_node_worker.js`, `tests/_node_thread.js`) packaged in `MANIFEST.in` so repeated JS asset checks reuse one V8/worker pool instead of spawning fresh Node subprocesses per assertion while keeping per-request global/timer/DOM isolation. - Preserve Node exit semantics (`process.exit`, `process.exitCode`, `require('process')` shim, throwing `uncaughtException`/`unhandledRejection` exit codes 1 and 7, virtual files, and dead-broker/mismatched-ID fast-fail recovery) and validate asset cache entries via file `stat`. - Migrate `tests/test_galaxy_gravity_floor.py`, `tests/test_galaxy_gravity_slider.py`, `tests/test_galaxy_gravity_slider_no_dead_zone.py`, and `tests/test_graph_engine_asset.py` onto the broker, and add 12 dedicated regression tests in `tests/test_node_runner_broker.py`. ### Independent Verification (`4a60679c58db8ccb88578f41be155e74f92410e1`) - `ruff check .`: PASS - `python scripts/check_commercial_manifest.py`: PASS - `python scripts/externalize_dashboard_assets.py`: PASS - `pyright --pythonpath .venv\Scripts\python.exe`: PASS (`0 errors, 0 warnings, 0 informations`) - Full unit suite (`pytest -o addopts= tests/ -q -rs -n 2 --dist loadfile`): `10774 passed, 106 skipped` (exit 0) - All 9 offline eval gates (`eval.harness` sample/codemem, `eval.ablation`, `eval.reinforcement`, `eval.adversarial_memory_security`, `eval.grounded`, `eval.code_arm`, `eval.spec_crawl`, `eval.evidence_contracts`): PASS - Two fresh independent Command Code reviews (`deepseek/deepseek-v4.1-flash --effort max`): **2/2 APPROVE** (`0` Blockers, `0` Majors). Non-overlapping with `#332` and `#333`. Ready for operator review and merge gate.
Summary
integrations/pi/package.jsonoverrides (@hono/node-server^2.1.8,hono^4.13.18) withintegrations/pi/npm-shrinkwrap.jsonto keep the audit gate green without post-install repair.honoand@hono/node-serveroverride pins inintegrations/pi/README.md.test_release_transitive_dependency_security_floors_cannot_regressintests/test_release_infrastructure.pyto pin@hono/node-server,hono,proxy-addr, and assert transitive floors across both top-level and nested shrinkwrap entries.Verification
pytest -o addopts="" -q tests/test_release_infrastructure.py tests/test_packaging.py tests/test_public_research_boundary.py tests/test_benchmark_evidence.py: 108 passed.ruff check .: passed.integrations/pi:npm run verify(23 passed),npm audit --omit=dev(0 vulnerabilities),npm audit --no-package-lock --include=dev(0 vulnerabilities).