Skip to content

fix(ci): harden run_preflight.ps1 parity and dependency verification - #335

Merged
Coding-Dev-Tools merged 2 commits into
mainfrom
fix/pi-audit-and-preflight-dx
Nov 19, 2026
Merged

Coding-Dev-Tools merged 2 commits into
mainfrom
fix/pi-audit-and-preflight-dx

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Summary

  • Replace Invoke-GateStep pipeline-capture return values with $script:lastStepPassed so native command failures and thrown exceptions cannot evaluate truthy via captured stdout and produce a false-green preflight banner.
  • Align run_preflight.ps1 with the full offline CI matrix: ruff check ., scripts/check_commercial_manifest.py, scripts/externalize_dashboard_assets.py, pyright, full pytest -o addopts= tests/ -q -rs --basetemp, scoped ENGRAPHIS_INDEX_ROOTS (including Python's tempfile.gettempdir()), and all 9 eval.* modules with both datasets.
  • Require Python 3.10+ / full-stack [test] imports outside -Fast (failing loudly with actionable Python 3.9 -Fast guidance instead of silent server/MCP skips), add PowerShell parser validation and CI-derived eval parity assertions in tests/test_release_infrastructure.py, and add comment-based parameter help.

Independent Verification (794f96ca31ac44ef1f0d20f8dd85239530e7f95d)

  • ruff check .: PASS
  • python scripts/check_commercial_manifest.py: PASS
  • python scripts/externalize_dashboard_assets.py: PASS
  • pyright --pythonpath .venv\Scripts\python.exe: PASS (0 errors, 0 warnings, 0 informations)
  • Full unit suite (pytest -o addopts= tests/ -q -rs -n 2 --dist loadfile): 10766 passed, 106 skipped (exit 0)
  • All 9 offline eval gates (eval.harness sample/codemem, eval.ablation, eval.reinforcement, eval.adversarial_memory_security, eval.grounded, eval.code_arm, eval.spec_crawl, eval.evidence_contracts): PASS
  • Two fresh independent Command Code reviews (deepseek/deepseek-v4.1-flash --effort max): 2/2 APPROVE (0 Blockers; rev1 noted 1 non-blocking execution-test gap on $LASTEXITCODE, rev2 0 Majors). Ready for operator review and merge gate.

Ensure run_preflight.ps1 verifies required test dependencies via real module
imports without stdout coercion, includes sqlite_vec with pip install -e ".[test]"
guidance, mirrors CI ENGRAPHIS_INDEX_ROOTS and eval gates, and expands release
infrastructure regression coverage.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-19T03:11:55.073593Z
We couldn’t complete this review. Comment @codex review to try again.
794f96c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

…nd execution tests

Run Python probes under Continue via Invoke-PythonStdout so stderr warnings do not raise NativeCommandError in PowerShell 5.1, check Python 3.10+ before Pyright, skip Pyright discovery in -Fast, prefer local/PATH/module ruff before bounded uv --no-project fallback, isolate PYTEST_ADDOPTS alongside ENGRAPHIS_INDEX_ROOTS, and add cross-shell subprocess behavioral regression tests.
@Coding-Dev-Tools
Coding-Dev-Tools merged commit 7645a7f into main Nov 19, 2026
29 checks passed
@Coding-Dev-Tools
Coding-Dev-Tools deleted the fix/pi-audit-and-preflight-dx branch November 19, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant