Repository navigation
feat(commercial): unify Pro/Team contract metadata and harden sync-key UX - #338
Merged
Merged
Conversation
…y UX Drive onboarding trial/checkout messaging and /memory/license plan metadata from commercial.py with path/mtime/size-safe caching, align dashboard Team plan cards and comparison tables with live granted capabilities, and guard explicit click-to-copy for sync keys.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…and harden ledger button action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engraphis/commercial.py::manifest()by(resolved path, st_mtime_ns, st_size)returningdeepcopy+reload(), expose consistentdays_by_plan/trial_dayson/memory/licenseand 501 refusals (engraphis/routes/memory.py,engraphis/routes/v2_api.py), and drivescripts/init.pyoffers and checkout URLs directly from the manifest with graceful fallbacks.engraphis/dashboard_assets/index.html,engraphis/dashboard_assets/ledger.js) to shipped capabilities and ensure sync-key display performs zero automatic clipboard writes (copy triggers only on explicit click), backed by executed DOM/Node tests and manifest hardening tests.offline-fixtures-ux-parity-20261118.json(7883aa21cd81...) and charts cleanly atoporigin/main(d9e39e91), preserving#334(engraphis/device_connect.py,docs/HOSTED_PLANS.md, andoffline-fixtures-connect-verify-20261117.json).Operator & Merge Coordination Notes
README_BENCHMARK_PINintests/test_documentation_contracts.pyand the raw image URL commit SHA inREADME.mdin a follow-up oncemaincontains the regenerated SVG.perf/core-sqlite-vector: Both PRs touchBENCHMARKS.md,README.md,docs/images/*.svg|png, andtests/test_benchmark_evidence.py. Whichever merges second must rebase and regenerate the unifiedoffline-fixtures-*.jsonartifact and charts atop updatedmain.Independent Verification (
ba80b26fa1f748863b57971d16bfe3d9958004e2)ruff check .,check_commercial_manifest.py,externalize_dashboard_assets.py: PASSpyright --pythonpath .venv\Scripts\python.exe: PASS (0 errors, 0 warnings, 0 informations)pytest -o addopts= tests/ -q -rs -n 2 --dist loadfile):10778 passed, 106 skipped(exit 0)deepseek/deepseek-v4.1-flash --effort max): 2/2 APPROVE (0Blockers; rev1 noted 1 non-blocking pre-existing post-mergeREADME_BENCHMARK_PINfollow-up; rev20Majors).