Skip to content

feat(commercial): unify Pro/Team contract metadata and harden sync-key UX - #338

Merged
Coding-Dev-Tools merged 4 commits into
mainfrom
feat/pro-team-ux-parity
Nov 20, 2026
Merged

Coding-Dev-Tools merged 4 commits into
mainfrom
feat/pro-team-ux-parity

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Summary

  • Align Pro (7-day trial) and Team (14-day trial) commercial UX, runtime payloads, and onboarding checkout targets with the checked-in entitlement manifest: cache engraphis/commercial.py::manifest() by (resolved path, st_mtime_ns, st_size) returning deepcopy + reload(), expose consistent days_by_plan / trial_days on /memory/license and 501 refusals (engraphis/routes/memory.py, engraphis/routes/v2_api.py), and drive scripts/init.py offers and checkout URLs directly from the manifest with graceful fallbacks.
  • Align Ledger dashboard Team copy (engraphis/dashboard_assets/index.html, engraphis/dashboard_assets/ledger.js) to shipped capabilities and ensure sync-key display performs zero automatic clipboard writes (copy triggers only on explicit click), backed by executed DOM/Node tests and manifest hardening tests.
  • Regenerate offline evidence offline-fixtures-ux-parity-20261118.json (7883aa21cd81...) and charts cleanly atop origin/main (d9e39e91), preserving #334 (engraphis/device_connect.py, docs/HOSTED_PLANS.md, and offline-fixtures-connect-verify-20261117.json).

Operator & Merge Coordination Notes

  • Post-merge README pin: Bump README_BENCHMARK_PIN in tests/test_documentation_contracts.py and the raw image URL commit SHA in README.md in a follow-up once main contains the regenerated SVG.
  • Evidence conflict coordination with perf/core-sqlite-vector: Both PRs touch BENCHMARKS.md, README.md, docs/images/*.svg|png, and tests/test_benchmark_evidence.py. Whichever merges second must rebase and regenerate the unified offline-fixtures-*.json artifact and charts atop updated main.

Independent Verification (ba80b26fa1f748863b57971d16bfe3d9958004e2)

  • ruff check ., check_commercial_manifest.py, externalize_dashboard_assets.py: PASS
  • pyright --pythonpath .venv\Scripts\python.exe: PASS (0 errors, 0 warnings, 0 informations)
  • Full unit suite (pytest -o addopts= tests/ -q -rs -n 2 --dist loadfile): 10778 passed, 106 skipped (exit 0)
  • All 9 offline eval gates: PASS
  • Two fresh independent Command Code reviews (deepseek/deepseek-v4.1-flash --effort max): 2/2 APPROVE (0 Blockers; rev1 noted 1 non-blocking pre-existing post-merge README_BENCHMARK_PIN follow-up; rev2 0 Majors).

…y UX

Drive onboarding trial/checkout messaging and /memory/license plan metadata from
commercial.py with path/mtime/size-safe caching, align dashboard Team plan cards
and comparison tables with live granted capabilities, and guard explicit
click-to-copy for sync keys.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-19T03:12:09.877432Z
We couldn’t complete this review. Comment @codex review to try again.
ba80b26 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Coding-Dev-Tools
Coding-Dev-Tools merged commit 8ae5ced into main Nov 20, 2026
30 checks passed
@Coding-Dev-Tools
Coding-Dev-Tools deleted the feat/pro-team-ux-parity branch November 20, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant