Repository navigation
SqlServer: make the Azure SQL tests conditional - #96
Merged
adamsitnik merged 2 commits intoNov 20, 2026
Merged
adamsitnik merged 2 commits into
adamsitnik merged 2 commits into
Conversation
Skip the DiskANN test and the hybrid search tests outside Azure SQL. The hybrid search tests are compiled again. Fixes CommunityToolkit#20
adamsitnik
reviewed
Nov 20, 2026
adamsitnik
left a comment
Contributor
There was a problem hiding this comment.
Overall it LGTM, but I have one idea how we could simplify SqlServerHybridSearchTests, PTAL at my comment.
@Laurianti thank you for fixing this!
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Azure SQL conformance-test changes.
No open issues 🎉
What changed in this PR
Makes Azure SQL–dependent SQL Server conformance tests conditional, addressing #20 without disabling hybrid search coverage.
Changes:
- Reports DiskANN as skipped outside Azure SQL instead of silently passing.
- Re-enables hybrid search tests, skipping them and avoiding fixture collection setup on unsupported targets.
- Restores hybrid search to the test-suite implementation checks.
| File | Description |
|---|---|
MEVD/test/SqlServer.ConformanceTests/Support/AzureSqlRequiredAttribute.cs |
Adds a shared skip helper and recognizes the local testcontainer as non-Azure SQL. |
MEVD/test/SqlServer.ConformanceTests/SqlServerTestSuiteImplementationTests.cs |
Removes the hybrid search exemption. |
MEVD/test/SqlServer.ConformanceTests/SqlServerIndexKindTests.cs |
Replaces the DiskANN early return with an explicit skip. |
MEVD/test/SqlServer.ConformanceTests/SqlServerHybridSearchTests.cs |
Adds conditional test execution and fixture initialization and cleanup. |
MEVD/test/SqlServer.ConformanceTests/SqlServer.ConformanceTests.csproj |
Restores compilation of hybrid search tests. |
Review effort: Balanced
adamsitnik
approved these changes
Nov 20, 2026
adamsitnik
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you @Laurianti !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DiskANN test and the hybrid search tests need Azure SQL. Outside Azure SQL they are now skipped.
Changes
SqlServerIndexKindTests.DiskAnnused to return early and count as passed. It is now skipped.SqlServerHybridSearchTests.csis compiled again. Each test is skipped outside Azure SQL, and the fixtures do not create their collections there, because xUnit reports a skip thrown from a class fixture as a failure.SqlServerTestSuiteImplementationTestsno longer ignoresHybridSearchTests<>.Tests
The 8 skipped tests are
DiskAnnand the 7 hybrid search tests. On Azure SQL the same 8 ran and passed.On Azure SQL I ran the two target frameworks one at a time. Run together against the same database, they use the same tables and fail.
Fixes #20