Repository navigation
Onboarding: Connect your AI keeps the frame's space above the phone's buttons - #2005
Merged
Merged
Conversation
… buttons On a phone the onboarding frame now keeps the fade's height above its pinned buttons for every step. Connect your AI still added room of its own below Sign out for the same fade, so scrolled to the end the step left about twice the gap the terms step and Welcome do. The step's own room is gone, and Sign out stops just above the fade like every other step's last line. The phone test now holds Sign out to within a pixel of the fade's top. It fails on main (48px over) and passes now.
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 22, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a phone, the onboarding frame now keeps the fade's height (32px) above its pinned buttons for every step (#2002). Connect your AI still added 48px of its own below Sign out for the same fade. So scrolled to the end, that step left about twice the gap that the terms step and Welcome do (about 100px from Sign out to the first button, against about 50px on terms).
The step's own room is gone. Sign out now stops just above the fade, like every other step's last line.
Test
connect-your-ai.test.tsx's phone test (light and dark, 390px) now holds Sign out to within a pixel of the fade's top, scrolled to the end. On main it fails (48px over); with this change it passes.Typecheck, lint and format are clean, and CI's real-browser list passes (370 tests). The step was screenshotted at 390px in light and dark beside the terms screen and Welcome.