Skip to content

Onboarding: Connect your AI keeps the frame's space above the phone's buttons - #2005

Merged
davidmckayv merged 1 commit into
mainfrom
connect-ai-phone-gap
Nov 22, 2026
Merged

davidmckayv merged 1 commit into
mainfrom
connect-ai-phone-gap

Conversation

@davidmckayv

Copy link
Copy Markdown
Contributor

On a phone, the onboarding frame now keeps the fade's height (32px) above its pinned buttons for every step (#2002). Connect your AI still added 48px of its own below Sign out for the same fade. So scrolled to the end, that step left about twice the gap that the terms step and Welcome do (about 100px from Sign out to the first button, against about 50px on terms).

The step's own room is gone. Sign out now stops just above the fade, like every other step's last line.

Test

connect-your-ai.test.tsx's phone test (light and dark, 390px) now holds Sign out to within a pixel of the fade's top, scrolled to the end. On main it fails (48px over); with this change it passes.

Typecheck, lint and format are clean, and CI's real-browser list passes (370 tests). The step was screenshotted at 390px in light and dark beside the terms screen and Welcome.

… buttons

On a phone the onboarding frame now keeps the fade's height above its
pinned buttons for every step. Connect your AI still added room of its
own below Sign out for the same fade, so scrolled to the end the step left
about twice the gap the terms step and Welcome do. The step's own room is
gone, and Sign out stops just above the fade like every other step's last
line.

The phone test now holds Sign out to within a pixel of the fade's top. It
fails on main (48px over) and passes now.
@davidmckayv
davidmckayv merged commit e3ccd5f into main Nov 22, 2026
22 checks passed
@davidmckayv
davidmckayv deleted the connect-ai-phone-gap branch November 22, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant