Repository navigation
Remove the Codecov upload - #11
Merged
Merged
Conversation
Every upload fails with "Token required because branch is protected", which fail_ci_if_error: false hides, so the coverage reaches nobody. Each tag set also overwrote coverage.txt, so only the last one would have been uploaded, file: is not an input of codecov-action v5, and the Windows job, which only runs go build, has no coverage to upload. Remove both upload steps, the -coverprofile flags that wrote the file, .codecov.yml, and the OS and GO variables that only the upload read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test jobs upload
coverage.txtto Codecov, and the uploads fail. In every job of the latestdeveloprun (42150656296), and of the earlier runs checked (41794468806 ondevelop, 42141620869 for #10), the uploader logsUpload queued for processing failed: {"message":"Token required because branch is protected"}. codecov-action v5 defaultsfail_ci_if_errorto false, so the job stays green and the coverage reaches nobody. Besides, each tag set overwritescoverage.txt, so only the last one would be uploaded;file:is not an input of v5, which warnsUnexpected input(s) 'file'; and the Windows job only runsgo build, so it has no coverage to upload.This removes both upload steps, the
-coverprofile=coverage.txtflags that wrote the file,.codecov.yml, which only Codecov reads, and the job-levelOSandGOvariables. Their only reader was the upload'senv_vars: OS,GO: no step reads them, and the example Makefiles that readOSdo not run in CI. The tests themselves run as before, with every tag set and-race.Left out:
sqlite_omit_localtime; both predate this change.Testing
Tags: vacuum, with no upload step (run 42162795021).cql-ci:go1.27pluslibsqlite3-dev), Go 1.27.3,--cpus 4: the fourgo testcommands, taken from the workflow file as written (go test -race -v -tags "",-tags "libsqlite3", the full set,-tags "sqlite_vacuum_full"), pass, and none writes acoverage.txt.