Repository navigation
Add reproducible module tooling and GitHub Actions - #8
Merged
Merged
Conversation
Declare the self-contained module without raising its language baseline beyond Go 1.11. Pin the generator that reproduces sql.go byte for byte. Replace the inactive Travis configuration and obsolete coverage tool installations with build, regeneration, vet, and test checks.
The module builds with Go 1.11, but versioned go run requires Go 1.17. Document the consumer and generator requirements separately without raising the module language version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository has no module manifest, and its Travis configuration depends on inactive CI and obsolete coverage-tool installations. Current Go module-mode commands cannot start on master.
Add a dependency-free Go 1.11 module and pin the goyacc revision that reproduces the committed sql.go byte for byte. Replace Travis with build, regeneration-diff, vet, and test checks in GitHub Actions; parser behavior is unchanged. The module builds with Go 1.11+; regeneration requires Go 1.17+.
Testing
linux/amd64, Docker, 4 CPUs. Go 1.16.15 rejects versioned generation, Go 1.17.13 regenerates identically, and Go 1.11.13 builds the module.
make -B sql.go && git diff --exit-code -- sql.gopasses with goyaccv0.0.0-20180926032708-9eb9690e392a. After merging master, the Go 1.27.3 build, regeneration check, vet, and all 85 tests pass. CovenantSQL develop and a branch replacement both passgo build -tags 'linux sqlite_omit_load_extension sqlite_omit_localtime' ./...andgo test -json -count=1 -tags 'linux sqlite_omit_load_extension sqlite_omit_localtime' ./xenomint/....