Skip to content

test(behat): seed the latest PHP row instead of creating it - #5

Merged
mrrobot47 merged 1 commit into
EasyEngine:developfrom
mrrobot47:test/latest-php-fixture
Nov 20, 2026
Merged

mrrobot47 merged 1 commit into
EasyEngine:developfrom
mrrobot47:test/latest-php-fixture

Conversation

@mrrobot47

Copy link
Copy Markdown
Member

What

The Behat scenario "A site on PHP "latest" is posted with the version it really runs" created its fixture with --type=php --php=latest and expected a latest row in the EasyEngine database. With EasyEngine/site-type-wp#255 and EasyEngine/site-type-php#127, --php=latest is stored as the concrete default version (8.5), so that fixture would no longer have a latest row and the scenario would fail on the next dev-develop run.

The fixture is now created on the default version and its php_version row is set to latest with the existing I set the column … in the EasyEngine database step (restored after the scenario). Rows stored as latest by older releases still exist until the site-command migration pins them, so ee dash init's runtime-resolve branch (ee shell … php -v) stays covered, and the scenario passes with or without the site-type change.

Test-only; no code change.

site-type-wp and site-type-php now store `--php=latest` as the concrete default version, so a site created with `--php=latest` no longer has a `latest` row. The fixture is created on the default version and its row set to `latest` with the existing database step (undone after the scenario), so the runtime-resolve branch stays covered with or without that change.
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 91cd06c0-6c46-4a96-9af3-7bff62727309

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mrrobot47
mrrobot47 merged commit 0c6d493 into EasyEngine:develop Nov 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant