Repository navigation
Fix: EE should ask values to use while requesting a LetsEncrypt certificate #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
goransh-walia
wants to merge
1
commit into
EasyEngine:develop
Choose a base branch
from
goransh-walia:fix/issue-1184-640
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
le-livehas no effect. Certificate requests always use the live Let's Encrypt directory.Nothing reads
le-live. The Let's Encrypt helper in theeasyengine/site-commandpackage hard-codeshttps://acme-v02.api.letsencrypt.org/directoryatvendor/easyengine/site-command/src/helper/Site_Letsencrypt.php:251. Its only configuration read iscloudflare-api-key. A user who setsle-live=falsestill receives live certificates. This defeats the purpose of the option and exposes users who expect staging to live rate limits.The directory URL must come from the
le-livevalue. When the value istrue, use the live directory. When it isfalse, use the staging directory (https://acme-staging-v02.api.letsencrypt.org/directory). The schema entry alone does not change behavior. The fix belongs in theeasyengine/site-commandpackage, or in this repository's integration with it.Also decide the default. The schema default is
false. Iffalseselects staging, existing installs switch from live to staging after this change.