Repository navigation
fix(migration): keep the saved php.ini out of the backup staging dir #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrrobot47
merged 51 commits into
EasyEngine:develop
from
mrrobot47:fix/migration-backup-dir
Nov 17, 2026
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
c4d5716
Merge branch 'develop' for v2.8.1
mrrobot47 aba31db
Merge branch 'develop' for v2.8.2
mrrobot47 6a9664a
Merge branch 'develop' for v2.9.0
mrrobot47 fc6fb37
Merge branch 'develop' for v2.9.1
mrrobot47 1b318aa
Merge branch 'develop' for v2.9.2
mrrobot47 5e20ed4
Merge branch 'develop' for v3.0.0
mrrobot47 ecaba66
Merge branch 'develop' for v3.0.1
mrrobot47 562d1a5
Merge branch 'develop' for v3.0.2
mrrobot47 7a425bf
Merge branch 'develop' for v3.0.3
mrrobot47 e15449b
Merge branch 'develop' for v3.0.4
mrrobot47 c706eb7
Merge branch 'develop' for v3.0.5
mrrobot47 d0cc3f7
Merge branch 'develop' for v3.0.5
mrrobot47 80e66f2
Merge branch 'develop' for v3.0.6
mrrobot47 fe76cc3
Merge branch 'develop' for v3.0.7
mrrobot47 25c67cb
Merge branch 'develop' for v3.0.8
mrrobot47 232a80b
Merge branch 'develop' for v3.0.9
PiyushKhurana 63bf95c
Merge branch 'develop' for v3.1.0
mrrobot47 0219361
Merge branch 'develop' for v3.2.0
mrrobot47 abe3d8d
Merge branch 'develop' for v3.2.1
mrrobot47 0c3e6aa
Merge branch 'develop' for v3.2.2
mrrobot47 d910ceb
Merge branch 'develop' for v3.2.3
mrrobot47 13be7f0
Merge branch 'develop' for v3.2.4
mrrobot47 f37e51e
Merge branch 'develop' for v3.2.5
mrrobot47 d47e480
Merge branch 'develop' for v3.3.0
mrrobot47 f5413bd
Merge branch 'develop' for v3.3.1
mrrobot47 ee76acc
Merge branch 'develop' for v3.3.2
mrrobot47 d930519
Merge branch 'develop' for v3.3.3
mrrobot47 c8dca43
Merge branch 'develop' for v3.3.4
mrrobot47 8f509d8
Merge branch 'develop' for v3.3.5
mrrobot47 2281c1b
Merge branch 'develop' for v3.4.0
mrrobot47 e2d2c9c
Merge branch 'develop' for v3.5.0
mrrobot47 c6fc3b1
Merge branch 'develop' for v3.5.1
mrrobot47 33a11a3
Merge branch 'develop' for v3.5.2
mrrobot47 be13167
Merge branch 'develop' for v3.5.3
mrrobot47 1703db6
Merge branch 'develop' for v3.6.0
mrrobot47 8a13026
Merge branch 'develop' for v3.6.1
mrrobot47 a3a5890
Merge branch 'develop' for v3.6.2
mrrobot47 6de478c
Merge branch 'develop' for v3.6.3
mrrobot47 2c078b8
Merge branch 'develop' for v3.6.4
mrrobot47 420d131
Merge branch 'develop' for v3.7.0
mrrobot47 4fc12e9
Merge branch 'develop' for v3.7.1
mrrobot47 092418c
Merge branch 'develop' for v3.7.2
mrrobot47 6a4898f
Merge branch 'develop' for v3.7.3
mrrobot47 b8c611b
Merge branch 'develop' for v3.7.4
mrrobot47 70a0854
Merge branch 'develop' for v3.7.5
mrrobot47 25d42db
Merge branch 'develop' for v3.7.6
mrrobot47 e40774c
Merge branch 'develop' for v3.8.0
mrrobot47 c5285f6
Merge branch 'develop' for v3.8.1
mrrobot47 50d8a3b
Merge branch 'develop' for v3.8.2
mrrobot47 abc9179
Merge branch 'develop' for v3.9.0
mrrobot47 8ff273f
fix(migration): keep the saved php.ini out of the backup staging dir
mrrobot47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create the backup root atomically so overlapping runs cannot share it.
If two migration runs overlap, they can select the same backup root. The
file_exists()check at lines 93-95 runs before either run creates the directory. A run whose guarded write then fails callsremove_backup()at line 172. That call deletes thephp.inibackup that the other run wrote to the same path, which is the only saved copy of the original file. The migratedphp.iniis not affected, but rollback loses its source.Create the timestamped root with a single
mkdir()call and check its return value. Add the PID suffix only when that call fails. Remove the root at the end ofup()when it is still empty, so unused runs leave no directory behind.