Skip to content

Snowflake: Preserve typed NULL table comments - #47

Merged
Vedin merged 2 commits into
compat-iceberg-ddl-versionfrom
oracle/qualify-table-comment-null-20261107
Nov 7, 2026
Merged

Vedin merged 2 commits into
compat-iceberg-ddl-versionfrom
oracle/qualify-table-comment-null-20261107

Conversation

@Vedin

@Vedin Vedin commented Nov 7, 2026

Copy link
Copy Markdown

Accept Snowflake CREATE TABLE t (id INT) COMMENT = NULL as a distinct typed table option. Empty strings, the string 'NULL' and absent comments remain distinct; column, stage, file-format and view comment grammars keep their existing string-only rules.

Saved Snowflake 10.40.102 reference: query 01c83e8c-0209-ab5f-0004-d66e05c171ae. Tests first show 4 expected behavior failures and 4 preserved controls. Rust 1.89 all-feature tests pass 1,583 cases with zero failures and 7 existing ignored; formatting and strict all-target/all-feature Clippy pass. Final committed bytes exactly match the qualified source.

The additive public enum variant requires exhaustive-match/serde consumer review. No runtime support or dependency repin is claimed; merged warehouse grammar #46 is preserved.

@Vedin
Vedin merged commit b3262f0 into compat-iceberg-ddl-version Nov 7, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant