Repository navigation
Snowflake: parse CREATE SCHEMA comment and retention options - #49
Merged
osipovartem merged 1 commit intoNov 13, 2026
Conversation
osipovartem
merged commit Nov 13, 2026
55cf93f
into
oracle/qualify-table-comment-null-20261107
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Snowflake literal schema properties without rewriting SQL:
Validation: 1,599 tests passed, seven ignored; all-target/all-feature strict Clippy and formatting passed. Independent read-only review approved the source. Coordinated DataFusion/Rustice builds and owning/Bronze tests passed with this exact parser revision.
The additive
CreateSchema.schema_optionsfield requires Rust consumers with exhaustive constructors/patterns to update. Serde defaults preserve older serialized input. Parsing does not imply runtime support.Reference: https://docs.snowflake.com/en/sql-reference/sql/create-schema