Skip to content

Snowflake: parse CREATE SCHEMA comment and retention options - #49

Merged
osipovartem merged 1 commit into
oracle/qualify-table-comment-null-20261107from
feat/snowflake-schema-options-20261113
Nov 13, 2026
Merged

osipovartem merged 1 commit into
oracle/qualify-table-comment-null-20261107from
feat/snowflake-schema-options-20261113

Conversation

@osipovartem

@osipovartem osipovartem commented Nov 13, 2026 •

Copy link
Copy Markdown

Parse Snowflake literal schema properties without rewriting SQL:

CREATE SCHEMA app COMMENT = 'application schema' DATA_RETENTION_TIME_IN_DAYS = 0;
  • Preserve ordered assignments, duplicates and literals for the execution consumer to validate.
  • Enable the syntax through a dialect capability; other dialects retain their existing valid forms.
  • Reject unrepresented CREATE modifiers rather than silently erasing them.
  • Add round-trip, malformed input, statement-boundary, serde and visitor controls.

Validation: 1,599 tests passed, seven ignored; all-target/all-feature strict Clippy and formatting passed. Independent read-only review approved the source. Coordinated DataFusion/Rustice builds and owning/Bronze tests passed with this exact parser revision.

The additive CreateSchema.schema_options field requires Rust consumers with exhaustive constructors/patterns to update. Serde defaults preserve older serialized input. Parsing does not imply runtime support.

Reference: https://docs.snowflake.com/en/sql-reference/sql/create-schema

@osipovartem
osipovartem merged commit 55cf93f into oracle/qualify-table-comment-null-20261107 Nov 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant