Skip to content

Generic: Visit native constraint characteristics - #54

Merged
Vedin merged 1 commit into
feat/snowflake-schema-modifiers-20261113from
feat/constraint-characteristics-visitor-20261115
Nov 15, 2026
Merged

Vedin merged 1 commit into
feat/snowflake-schema-modifiers-20261113from
feat/constraint-characteristics-visitor-20261115

Conversation

@Vedin

@Vedin Vedin commented Nov 15, 2026

Copy link
Copy Markdown

Native constraint characteristics had no dedicated visitor callback, so consumers could miss RELY in view columns, Hive definitions, domains and supplied ASTs. Add default pre/post hooks to Visitor and VisitorMut on the characteristics type, preserving the actual borrowed instance, default continuation and early breaks. Grammar, AST fields and serialization stay unchanged.

Validation: 1,634 all-feature tests pass with zero failures and seven existing ignored tests, including 47 documentation tests. Configured Rust 1.89 all-target/all-feature Clippy and fmt pass. Four new controls cover native containers, borrowed identity versus equal clones, mutable post-break propagation and existing visitors. The test-first inert-hook baseline records one pass and three failures; a subsequent fixture-only lint correction uses returned errors and a type alias without lint allowances.

Base: feat/snowflake-schema-modifiers-20261113 at merged parser 847d4cf. This parser prerequisite does not activate the separate Rustice consumer or retire engine XFAILs. Draft pending independent review and exact-head CI.

@Vedin
Vedin marked this pull request as ready for review November 15, 2026 05:02
@Vedin
Vedin merged commit ee24d34 into feat/snowflake-schema-modifiers-20261113 Nov 15, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant