Repository navigation
Generic: Visit native constraint characteristics - #54
Merged
Vedin merged 1 commit intoNov 15, 2026
Conversation
Vedin
marked this pull request as ready for review
November 15, 2026 05:02
Vedin
merged commit Nov 15, 2026
ee24d34
into
feat/snowflake-schema-modifiers-20261113
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native constraint characteristics had no dedicated visitor callback, so consumers could miss RELY in view columns, Hive definitions, domains and supplied ASTs. Add default pre/post hooks to Visitor and VisitorMut on the characteristics type, preserving the actual borrowed instance, default continuation and early breaks. Grammar, AST fields and serialization stay unchanged.
Validation: 1,634 all-feature tests pass with zero failures and seven existing ignored tests, including 47 documentation tests. Configured Rust 1.89 all-target/all-feature Clippy and fmt pass. Four new controls cover native containers, borrowed identity versus equal clones, mutable post-break propagation and existing visitors. The test-first inert-hook baseline records one pass and three failures; a subsequent fixture-only lint correction uses returned errors and a type alias without lint allowances.
Base: feat/snowflake-schema-modifiers-20261113 at merged parser 847d4cf. This parser prerequisite does not activate the separate Rustice consumer or retire engine XFAILs. Draft pending independent review and exact-head CI.