Repository navigation
Preserve declared CTAS field metadata - #183
Merged
osipovartem merged 1 commit intoNov 12, 2026
Merged
osipovartem merged 1 commit into
osipovartem merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve metadata supplied by a custom type planner for explicit CTAS target columns. The current
cast(column, target_type).alias(target_name)projection drops declared metadata. In Rustice this losesVARCHAR(n)constraints and can make an invalidCREATE OR REPLACE ... AS SELECTreplace the original table.Apply declared metadata to the existing outer alias, only when it is nonempty. Declared keys override inherited keys using the existing alias merge policy; unrelated source keys are retained. Strict casts, qualified input references, nullability and the unannotated/inferred CTAS paths stay unchanged. No new execution operator, per-row conversion or runtime validator is introduced.
Validation
datafusion-sqlsql_integration: 664 passed, 0 failed.rustfmt --checkandgit diff --checkpass.The initial new unannotated control incorrectly expected Utf8 instead of the existing Utf8View default. The corrected control now passes; no existing expectations were changed.
This qualifies SQL planning, not full Rustice runtime behavior. Rustice native/wire CTAS acceptance and dependency adoption are a separate follow-up. Clearing inherited keys absent from the declared target remains outside this change.