Repository navigation
Pin native schema modifiers and refuse lossy planning - #190
Merged
osipovartem merged 1 commit intoNov 13, 2026
Merged
osipovartem merged 1 commit into
osipovartem merged 1 commit into
Conversation
osipovartem
merged commit Nov 13, 2026
1d91aac
into
df55-physical-udf-instance
19 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Supports the bounded Oracle schema work; parser change: Embucket/datafusion-sqlparser-rs#52.
Rationale for this change
Native Snowflake CREATE SCHEMA modifiers must survive parsing. The generic DataFusion schema plan does not implement replacement, transient lifetime, or managed-access authorization, so silently dropping those flags would be incorrect.
What changes are included in this PR?
874cfbb8, retaining the native schema modifiers.The base is
df55-physical-udf-instance, the integration branch already used by Rustice and recent dependency PRs. No existing fork patches are removed.Are these changes tested?
clippy --all-targets --all-features -- -D warningson Rust 1.97: passed.cargo fmt --all -- --checkandgit diff --check: passed.The parser itself separately passes 1,625 tests with seven existing ignored, and strict all-target/all-feature Clippy. Local qualification is reported separately from remote CI.
Are there any user-facing changes?
Generic planning now explicitly refuses modifiers it cannot execute. The dependency's CREATE SCHEMA AST gains three boolean fields, with serde defaults for older serialized input; downstream Rust constructors must account for the new fields.