Repository navigation
Conversation
Vedin
marked this pull request as ready for review
November 15, 2026 14:50
Vedin
merged commit Nov 15, 2026
d935c23
into
fix/schema-modifiers-parser-pin-20261113
39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Dependency prerequisite for the local Snowflake constraint-reliance workflow; no linked issue.
Rationale for this change
DFParser rejects
CREATE TABLE NE (ID INT PRIMARY KEY NOT ENFORCED RELY)at its direct parser dependency. Consumers also need one native constraint-characteristics visitor API throughout the DataFusion graph to reject unsupported declarations before effects.What changes are included in this PR?
Pin the direct parser dependency to merged
ee24d34fe4e49bc6d405a4da163a555bdabd9879and update its two lockfile source entries. Versions, default-feature policy and requestedstd/visitorfeatures stay identical. Add three parser controls covering the original no-RELY declaration, RELY syntax, and typed RELY/NORELY characteristics with the original borrowed visitor node. No DataFusion planner, optimizer or execution code changes.The exact existing base branch is
fix/schema-modifiers-parser-pin-20261113, now including security prerequisite #192 ated46d575686763cede68d5dc19685bcd480cb730. The initial inherited Quinn audit failure is retained in the original #191 CI attempt; the separately reviewed minimal patch is merged through that base ancestry. This PR's current diff remains the parser manifest, two source URLs and parser tests.Are these changes tested?
The old parser gives the retained RED: one control passes and RELY fails at line 1, column 50. The final combined source passes all three native parser controls, full configured Clippy (
--locked --all-targets --all-features -- -D warnings), formatting and diff checks. The full mandatory extended workspace command passes 10,785 tests, zero failed, ten ignored across 72 summaries, plus all 509 custom sqllogictest files and the 115-test fuzz suite.Locked all-feature metadata confirms exactly one EE parser/derive family. Actual cargo-audit 0.22.2 against the same recorded RustSec database reports zero vulnerabilities under the unchanged repository policy; no new ignores. The tested tree remains
ce3cf54a93cdc7a7da8b5a85a2c69419fddac035. Checks use configured Rust 1.97.0, an isolated target and at most two compile jobs; the custom SLT runner independently selects eight test threads. Historical parser-only and security-only qualifications remain separate.Are there any user-facing changes?
Snowflake RELY/NORELY syntax is retained in the native parser AST. This dependency change grants no optimizer trust and does not claim Rustice enforcement, lifecycle or wire compatibility. No Rustice pin is changed here.