Skip to content

fix: unify the native constraint-reliance parser pin - #191

Merged
Vedin merged 2 commits into
fix/schema-modifiers-parser-pin-20261113from
feat/unify-constraint-reliance-parser-20261115
Nov 15, 2026
Merged

Vedin merged 2 commits into
fix/schema-modifiers-parser-pin-20261113from
feat/unify-constraint-reliance-parser-20261115

Conversation

@Vedin

@Vedin Vedin commented Nov 15, 2026 •

Copy link
Copy Markdown

Which issue does this PR close?

Dependency prerequisite for the local Snowflake constraint-reliance workflow; no linked issue.

Rationale for this change

DFParser rejects CREATE TABLE NE (ID INT PRIMARY KEY NOT ENFORCED RELY) at its direct parser dependency. Consumers also need one native constraint-characteristics visitor API throughout the DataFusion graph to reject unsupported declarations before effects.

What changes are included in this PR?

Pin the direct parser dependency to merged ee24d34fe4e49bc6d405a4da163a555bdabd9879 and update its two lockfile source entries. Versions, default-feature policy and requested std/visitor features stay identical. Add three parser controls covering the original no-RELY declaration, RELY syntax, and typed RELY/NORELY characteristics with the original borrowed visitor node. No DataFusion planner, optimizer or execution code changes.

The exact existing base branch is fix/schema-modifiers-parser-pin-20261113, now including security prerequisite #192 at ed46d575686763cede68d5dc19685bcd480cb730. The initial inherited Quinn audit failure is retained in the original #191 CI attempt; the separately reviewed minimal patch is merged through that base ancestry. This PR's current diff remains the parser manifest, two source URLs and parser tests.

Are these changes tested?

The old parser gives the retained RED: one control passes and RELY fails at line 1, column 50. The final combined source passes all three native parser controls, full configured Clippy (--locked --all-targets --all-features -- -D warnings), formatting and diff checks. The full mandatory extended workspace command passes 10,785 tests, zero failed, ten ignored across 72 summaries, plus all 509 custom sqllogictest files and the 115-test fuzz suite.

Locked all-feature metadata confirms exactly one EE parser/derive family. Actual cargo-audit 0.22.2 against the same recorded RustSec database reports zero vulnerabilities under the unchanged repository policy; no new ignores. The tested tree remains ce3cf54a93cdc7a7da8b5a85a2c69419fddac035. Checks use configured Rust 1.97.0, an isolated target and at most two compile jobs; the custom SLT runner independently selects eight test threads. Historical parser-only and security-only qualifications remain separate.

Are there any user-facing changes?

Snowflake RELY/NORELY syntax is retained in the native parser AST. This dependency change grants no optimizer trust and does not claim Rustice enforcement, lifecycle or wire compatibility. No Rustice pin is changed here.

@Vedin
Vedin marked this pull request as ready for review November 15, 2026 14:50
@Vedin
Vedin merged commit d935c23 into fix/schema-modifiers-parser-pin-20261113 Nov 15, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant