Repository navigation
Conversation
…VM harness The watchdog and the transaction were only exercised with fakes. The harness now runs the real modules and the unit from the role's template under a guest's systemd and NetworkManager: a change whose owner crashes is restored by the worker after its deadline, the same holds when the worker is killed too and systemd restarts it, and a change committed in time is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the connectivity watchdog to the KVM harness: the real transaction and watchdog worker, with the unit from the role's template, run under a guest's systemd and NetworkManager. It changes no role, module or host behaviour.
Measured in a disposable offline guest on NetworkManager 1.54.3: a change whose owner crashes before committing is restored by the worker after its deadline (13 s against a 12 s deadline); the same holds when the worker is also killed with SIGKILL and systemd restarts it within a second; a change committed in time is left in place after its deadline.
Not covered: a reboot (the boot-id path, still tested with fakes only), and the guest's NetworkManager reported connectivity checking off from the start, so the recorded
rolled_backphase, written only after the reload returns, is the evidence that the reload ran.