Repository navigation
fix(reports): avoid quoting string identifiers in template builder and add unit tests - #371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataformTemplateBuilder.create(resolveVariable) so deferred string placeholders are returned raw instead of wrapped in extra single quotes ('...'').DataformTemplateBuilder.create,HTTPArchiveReports.getReport, andHTTPArchiveReports.getMetric, and guardlistReports()when_reportsis absent.DataformTemplateBuilderand add a unit test suite (tests/reports.test.js) using Node's built-in test runner that verifies template resolution, report/metric validation, and SQL compilation for all configured metrics.npm testtopackage.jsonand the GitHub Actions CI workflow (.github/workflows/ci.yaml).