Repository navigation
[Logging-View]: Enhancements and features - #650
Draft
JavierRibaldelRio wants to merge 18 commits into
Draft
JavierRibaldelRio wants to merge 18 commits into
JavierRibaldelRio wants to merge 18 commits into
Conversation
5029cf1 stopped committing credits.snapshot.json and the contributor avatars, because they are personal data in a public repository, and made them build-time artefacts instead. Nothing in the E2E job builds them: the workflow builds the four renderers and runs Playwright, so a fresh clone has no snapshot, getAboutCredits() returns an empty list and both About tests fail on `#contributors li` never appearing. It still passed locally, where a previous packaging run had left the files on disk. The suite cannot fetch them either. The About tests assert that the screen is entirely network-free, and making every pull request page through the GitHub commits API would be slow and fail for reasons unrelated to the change under test. So the renderer build now seeds a fixed, offline fixture: three members with distinct descending commit counts, a GitHub login each, and real PNG avatars encoded on the spot, so nothing binary needs committing. A generated snapshot already on disk is left untouched, so a developer's own build stays what the About tests exercise locally; it is replaced only when it lists nobody, is unreadable, or references an avatar that is gone, all of which would fail the same assertions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
Simple Mode
Normal mode