Skip to content

Small Improvements to CSV converter - #428

Merged
lihaoahil merged 2 commits into
masterfrom
csv_converter
Nov 18, 2026
Merged

lihaoahil merged 2 commits into
masterfrom
csv_converter

Conversation

@kevScheuer

@kevScheuer kevScheuer commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Bugs addressed:

  • The normalization integral csv sometimes printed x+-j0.0 strings, which broke abilities to recognize it as a complex value. Now only prints x+jy or x-jy values
  • Only scaled production parameters were output by the FitConverter. This could be a potential source of confusion, and was unnecessary, because the scale parameters are also saved separately. The non-scaled production parameters are now returned.
  • Normalization integrals are now the acceptance-corrected ampInt ones when acceptance-corrected results are requested.
  • Warning suppression now also applies to the amplitude parser.
  • Absolute file paths are now written to the file columns of the csv, clearing up confusion when combining multiple csv files together

QOL:

  • Many of the methods in FitConverter are better suited for the AmplitudeParser class, and so were moved there
  • Many parser functions were promoted to public and/or static so that other classes can make easy use of them.

Bugs addressed:
- The normalization integral csv sometimes printed
  "a+-j0.0" strings, which broke abilities to
  recognize it as a complex value. Now only prints
  "a+jb" or "a-jb" values
- Only scaled production parameters were output by
  the FitConverter. This could be a potential
  source of confusion, and was unnecessary,
  because the scale parameters are also saved
  separately. The non-scaled production parameters
  are now returned.
- Normalization integrals are now the acceptance-
  corrected "ampInt" ones when
  acceptance-corrected results are requested.
- Warning suppression now also applies to the
  amplitude parser.

QOL:
- Many of the methods in FitConverter are better
  suited for the AmplitudeParser class, and so
  were moved there
- Many parser functions were promoted to public
  and/or static so that other classes can make
  easy use of them.
@gluex

gluex commented Nov 12, 2026

Copy link
Copy Markdown

Test status for this pull request: SUCCESS

Summary: summary.txt
Logs: results/log

Build log: make_csv_converter.log
Build report: report_csv_converter.txt

@gluex

gluex commented Nov 17, 2026

Copy link
Copy Markdown

Test status for this pull request: SUCCESS

Summary: summary.txt
Logs: results/log

Build log: make_csv_converter.log
Build report: report_csv_converter.txt

@lihaoahil lihaoahil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kevin, thanks for the fixes! I have ran some tests with both my SDME fits and amplitude fits, and they look good to me.

@lihaoahil
lihaoahil merged commit 5ffd9a1 into master Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants