Repository navigation
ReadoutDataManager: propagate biased/forced MC event weight through trigger - #1188
Open
bloodyyugo wants to merge 1 commit into
Open
bloodyyugo wants to merge 1 commit into
bloodyyugo wants to merge 1 commit into
Conversation
…riggers Buffers the input event's weight (e.g. a forced-conversion weight written by SLIC's ForcedPairConversion plugins) against simulation time, and recovers it by trigger time when a triggered output event is synthesized. BaseLCSimEvent is a brand new EventHeader rather than a copy of the triggering input event, and its own getWeight() is hardcoded to 1.0, so without this the forced-conversion weight was silently lost at the trigger stage. The buffer is pruned of entries older than 500 ns; triggers firing outside that window fall back to the default weight of 1, which is correct for genuine uncorrelated background/pulser triggers. Needed for the forced pair-conversion WAB biased-sampling MC technique; independent of the mc_v5.3.1-lowp-bugfix production branch.
mgignac
approved these changes
Nov 18, 2026
mgignac
left a comment
Collaborator
There was a problem hiding this comment.
Was initially worried the buffer would grow too large, but I see it's cleared periodically.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffers the input event's weight (e.g. a forced-conversion weight written by SLIC's ForcedPairConversion plugins) against simulation time, and recovers it by trigger time when a triggered output event is synthesized. BaseLCSimEvent is a brand new EventHeader rather than a copy of the triggering input event, and its own getWeight() is hardcoded to 1.0, so without this the forced-conversion weight was silently lost at the trigger stage. The buffer is pruned of entries older than 500 ns; triggers firing outside that window fall back to the default weight of 1, which is correct for genuine uncorrelated background/pulser triggers.
Needed for the forced pair-conversion WAB biased-sampling MC technique