Skip to content

Load the SQAP's merged dependencies element - #92

Merged
slominskir merged 1 commit into
mainfrom
load-sqap-19bcfba
Nov 18, 2026
Merged

slominskir merged 1 commit into
mainfrom
load-sqap-19bcfba

Conversation

@slominskir-coding-agent

Copy link
Copy Markdown
Contributor

Summary

Loads the SQAP's elements of revision 19bcfba (https://code.jlab.org/acc/iac/docs/sqap/-/merge_requests/22):

  • One dependencies element. "Dependencies on other ACS products recorded in the build files or README" (acs-dependencies-recorded, Design) is merged into dependencies-recorded. The merged element is "Dependencies recorded in the build files or README: acquired software with its versions, and other ACS products, including their servers, schemas and web services", at ○ ● ● ●. A checklist asks once for the record of a product's dependencies, and acs-dependencies-recorded is retired.
  • The group is "Dependencies". The six dependency elements' phase is now Dependencies instead of Acquired Software, so the dialog shows "Dependencies · §6.1.5", and the dependency elements sit together within Required and Recommended.

03_sqa_elements.sql is regenerated, now with 16 elements. The links point at the SQAP's source at 19bcfba, as #91 made them. The user guide's four links to section 4.3 name the new revision.

Upgrade script. 2.11.1_sqap_dependencies_merged.sql:

  1. Sets each element's row to what a new database loads, including the section links.
  2. Lists the products that recorded the two elements with different statuses, for review: dependencies-recorded keeps its own status there.
  3. Moves a status recorded for acs-dependencies-recorded to dependencies-recorded where a product has none there.
  4. Deletes the retired element and anything recorded or provided for it.

It replaces #91's 2.11.1_sqap_draft_section_links.sql. That script was merged but never released, and this one sets the same links (at the new revision). Keeping both would have needed them run in a set order, because the older one would point the links back at 8905d54.

Release notes

  • One "Dependencies recorded" element (SQAP revision 19bcfba): the SQAP merged "ACS dependencies recorded" into "Dependencies recorded", which now covers acquired software and other ACS products, including their servers, schemas and web services. The dependency elements are grouped as Dependencies (Load the SQAP's merged dependencies element #92)
  • SQAP links go to the revision SIM loads: each element's § link, the SQA Elements dialog's SQAP §4.4 link, the assessment dialog's SQAP §4.3 link and the user guide's links to 4.3.1–4.3.4 open the SQAP's source on code.jlab.org at that revision, instead of the released v1.0.0, which lacks many of the elements (Link draft SQA elements to the SQAP's source at their revision #91)

Oracle DB Migration Notes

Run on a database at 2.11.0, as SIM_OWNER:

  1. container/oracle/upgrade/2.11.1_sqap_dependencies_merged.sql: updates the 16 SQA_ELEMENT rows (wording, group, links, order, levels, SQAP revision). It moves what was recorded of the retired acs-dependencies-recorded to dependencies-recorded where nothing is recorded there, and deletes the retired element. Its first query lists products that recorded the two with different statuses; review those, since dependencies-recorded keeps its own.

Checks

  • ./gradlew build: passes.
  • ./gradlew integrationTest against a new stack built from this branch: 92 tests, 0 failed. The sim log has no errors besides the tests' rejection cases.
  • uv run --locked zensical build --strict: no issues.
  • Upgrade script, on that stack set back to 2.11.0's state (17 elements with v2.11.0's rows, and the retired element), in two cases:
    • Only acs-dependencies-recorded recorded (GAP, with link and note): the status, link and note moved to dependencies-recorded.
    • Both recorded, differently (MET and GAP): the query listed the product, and dependencies-recorded kept GAP.
    • Both cases: the retired element and its record were deleted, and the 16 SQA_ELEMENT rows came out identical to a new database's.
  • Not checked: the script on a copy of acctest's or production's database, so I don't know how many statuses it will move there.

Decisions

  • The person asked whether the two dependency elements were distinct, whether the distinction was useful, and for the dependency elements to be grouped. They chose to merge them in the SQAP (sqap!22) over only relabelling.
  • One upgrade script for the release, replacing Link draft SQA elements to the SQAP's source at their revision #91's unreleased one, so there is no order to get wrong.
  • Where both were recorded differently, dependencies-recorded keeps its own status, and the script lists those products instead of choosing between them.

Prepared-by: Anthropic Claude Code:claude-opus-5-5

🤖 Generated with Claude Code

The SQAP (acc/iac/docs/sqap!22, revision 19bcfba) merged "Dependencies
on other ACS products recorded in the build files or README" into
"Dependencies recorded in the build files or README: acquired software
with its versions, and other ACS products, including their servers,
schemas and web services", and named the group of dependency elements
Dependencies instead of Acquired Software. A checklist now asks once for
the record of a product's dependencies, and shows it with the other
dependency elements; acs-dependencies-recorded is retired.

03_sqa_elements.sql is regenerated: 16 elements. Existing databases
need container/oracle/upgrade/2.11.1_sqap_dependencies_merged.sql,
which sets each element's row to what a new database loads, moves a
status recorded for the retired element to dependencies-recorded where
a product has none there, after listing the products that recorded the
two differently, and deletes the retired element. It also sets the
section links #91 changed, so it replaces that pull
request's unreleased 2.11.1_sqap_draft_section_links.sql: one script
for the release, with no order to get wrong.

The user guide's links to section 4.3 name the new revision.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@slominskir-coding-agent slominskir-coding-agent Bot added the source::ai Prepared by an AI coding agent label Nov 18, 2026
@slominskir-coding-agent slominskir-coding-agent Bot added the source::ai Prepared by an AI coding agent label Nov 18, 2026
@slominskir
slominskir merged commit 4e5d281 into main Nov 18, 2026
7 checks passed
@slominskir
slominskir deleted the load-sqap-19bcfba branch November 18, 2026 16:44
@slominskir-coding-agent slominskir-coding-agent Bot mentioned this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source::ai Prepared by an AI coding agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant