Repository navigation
Load images with ImageIO in the PR commenter - #24
Merged
Merged
Conversation
ImageMagick_jll v7.1.2001 requires libgs.so.9, which the resolved Ghostscript_jll v10 does not provide. Loading every image therefore failed, VisualRegressionTests returned PROCESSING_ERROR with a difference of 1.0, and the PR comment reported 1.0 for every figure. FileIO loads PNG files with ImageIO when it is installed, so the script now installs ImageIO instead of ImageMagick. The comment now reports the status instead of the difference for results with PROCESSING_ERROR, and the log prints the corresponding errors. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison posted on JuliaControl/ControlSystems.jl#1106 (comment) reported a difference of 1.0 for all 11 figures, although the figures were unchanged.
Cause:
ImageMagick_jll v7.1.2001requireslibgs.so.9, while the resolver installsGhostscript_jll v10.8.0, which provideslibgs.so.10. ImageMagick fails to initialize (run log),loadthrows inVisualRegressionTests.compare_images, and the result has statusPROCESSING_ERRORwithdiff = 1.0. The commenter printed thisdiffas if it were a measured difference.Changes in
utils/pr_commenter.jl:ImageIOinstead ofImageMagick. FileIO uses ImageIO (PNGFiles) for PNG files when it is installed, so ImageMagick is no longer used for loading.PROCESSING_ERROR, and print the corresponding errors in the log.Verified locally (under
xvfb-run, with the same package versions as the CI run) against ControlSystems master: all 11 figures load and the differences are between 0.005 and 0.049. Five of them exceed the tolerances ingen_figures(0.02 to 0.03); these are rendering differences between the reference machine and the current environment, not caused by the PR.Host: demeter2, session 5a6c4396-72cd-4580-a020-cb80f89c3346, working directory
~/repos/ControlExamplePlots.jl🤖 Generated with Claude Code