Skip to content

CompatHelper: install Julia with setup-julia; relative tolerance in sensitivity tests - #1100

Merged
baggepinnen merged 2 commits into
masterfrom
fb/compathelper-setup-julia
Nov 10, 2026
Merged

baggepinnen merged 2 commits into
masterfrom
fb/compathelper-setup-julia

Conversation

@baggepinnen

@baggepinnen baggepinnen commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

The GitHub-hosted ubuntu-latest runner now resolves to the ubuntu-26.04 image, which does not include Julia. The CompatHelper workflow invokes julia without installing it first and therefore fails with julia: command not found, see for example https://github.com/JuliaControl/ControlSystemIdentification.jl/actions/runs/42768500356/job/129670529185.

This PR adds a julia-actions/setup-julia step before the CompatHelper steps.

In addition, the two tests in test_connections.jl that compare sensitivity functions through the H-infinity norm of their difference now use a tolerance relative to the norm of the system. The systems are randomly generated, and the absolute tolerance 1e-8 occasionally failed (1.016e-8 was observed in CI of this PR).


Host: demeter2, session: session_01JGy8YbuXmUBGoYmsoZY5uK, working directory: /home/baggepinnen/.julia/dev

🤖 Generated with Claude Code

The ubuntu-latest runner image no longer includes Julia.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@JuliaControlBot

Copy link
Copy Markdown

This is an automated message.
Plots were compared to references. 6/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.0 Reference New
⚠️ 0.021 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
✔️ 0.013 Reference New

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (3035fbd) to head (76c63cd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          42       42           
  Lines        6177     6177           
=======================================
  Hits         5701     5701           
  Misses        476      476           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The systems are randomly generated, and an absolute tolerance of 1e-8 on the
H-infinity norm of the difference occasionally fails (1.016e-8 observed).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@baggepinnen baggepinnen changed the title CompatHelper: install Julia with setup-julia CompatHelper: install Julia with setup-julia; relative tolerance in sensitivity tests Nov 10, 2026
@baggepinnen
baggepinnen merged commit e1dae9d into master Nov 10, 2026
5 checks passed
@baggepinnen
baggepinnen deleted the fb/compathelper-setup-julia branch November 10, 2026 09:46
@JuliaControlBot

Copy link
Copy Markdown

This is an automated message.
Plots were compared to references. 6/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.0 Reference New
⚠️ 0.021 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
✔️ 0.013 Reference New

@JuliaControlBot

Copy link
Copy Markdown

This is an automated message.
Plots were compared to references. 6/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.0 Reference New
⚠️ 0.021 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
✔️ 0.013 Reference New

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants