Skip to content

added: improving type-stability of NonLinMPC and MovingHorizonEstimator internals - #510

Merged
franckgaga merged 1 commit into
mainfrom
type_stability_obj_ob
Nov 10, 2026
Merged

franckgaga merged 1 commit into
mainfrom
type_stability_obj_ob

Conversation

@franckgaga

@franckgaga franckgaga commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Theoretically if the branches evaluate to true, the returned type will be typeof(J), but it will be Nothing if it evaluates to false. Let's see if adding an explicit return nothing improves the benchmarks.

…mator` callbacks

Theoritically if the branches evaluate to `true`, the returned type will be `typeof(J)`, but it will be `Nothing` if it evaluates to `false`. Let's see if it improves the benchmarks.
@codecov-commenter

codecov-commenter commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (cfa0cfd) to head (805a670).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   97.23%   97.30%   +0.07%     
==========================================
  Files          28       28              
  Lines        7095     7099       +4     
==========================================
+ Hits         6899     6908       +9     
+ Misses        196      191       -5     
Flag Coverage Δ
unittests 97.30% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga

Copy link
Copy Markdown
Member Author

No difference on the benchmarks. The return type was correctly inferred, presumably as a Union, with no impact on the performances.

Will still merge since this repo follow the style rule of always including an explicit return keyword.

@franckgaga
franckgaga merged commit e7420db into main Nov 10, 2026
19 checks passed
@franckgaga
franckgaga deleted the type_stability_obj_ob branch November 10, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants