Repository navigation
added: improving type-stability of NonLinMPC and MovingHorizonEstimator internals - #510
Merged
Merged
Conversation
…mator` callbacks Theoritically if the branches evaluate to `true`, the returned type will be `typeof(J)`, but it will be `Nothing` if it evaluates to `false`. Let's see if it improves the benchmarks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 97.23% 97.30% +0.07%
==========================================
Files 28 28
Lines 7095 7099 +4
==========================================
+ Hits 6899 6908 +9
+ Misses 196 191 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
No difference on the benchmarks. The return type was correctly inferred, presumably as a Will still merge since this repo follow the style rule of always including an explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theoretically if the branches evaluate to
true, the returned type will betypeof(J), but it will beNothingif it evaluates tofalse. Let's see if adding an explicitreturn nothingimproves the benchmarks.