Skip to content

changed: cleaner and shorter code in get_nonlinobj_op - #513

Merged
franckgaga merged 3 commits into
mainfrom
cleanup_obj_op
Nov 11, 2026
Merged

franckgaga merged 3 commits into
mainfrom
cleanup_obj_op

Conversation

@franckgaga

@franckgaga franckgaga commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Now that dynamic dispatch is totally assumed for the 3 closures of the nonlinear objective functions (see #511), there are no good reasons to define parameters in the signatures e.g. the explicit Vararg{T, N}. I deleted all this crap and used explicit splatting operator ... in the signatures instead.

The precompilation time and the TTFX at construction is not impacted by this PR at all. Let's see if it impacts the benchmarks.

Dynamic dispatch is totally assumed in `get_nonlinobj_op`, so explicit `Vararg` is now uselessly complex.
@codecov-commenter

codecov-commenter commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (9bb5cfe) to head (c217d01).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   97.23%   97.38%   +0.14%     
==========================================
  Files          28       28              
  Lines        7101     7077      -24     
==========================================
- Hits         6905     6892      -13     
+ Misses        196      185      -11     
Flag Coverage Δ
unittests 97.38% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga

franckgaga commented Nov 11, 2026 •

Copy link
Copy Markdown
Member Author

No differences on the runtime benchmarks. Let's merge!

@franckgaga
franckgaga merged commit 9c6a596 into main Nov 11, 2026
20 checks passed
@franckgaga
franckgaga deleted the cleanup_obj_op branch November 11, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants