Repository navigation
Conversation
Signed-off-by: YvesCesar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several inputs of the image and the stack were resolved at build or start time without a fixed version or a checksum:
install-php-extensionscame fromreleases/latestand ran as root,wp-cli.pharwas downloaded from thegh-pagesbranch with acurlthat did not fail on HTTP errors and was never verified,composer,nginxandmariadbused their default tags, and the workflows referenced actions by mutable tags or@master.Changes
install-php-extensionsis copied frommlocati/php-extension-installer:2.13.2pinned by digest.curl -fsSLand checked against the published SHA-512 before use.composer:2.11.2,nginx:1.31.8andmariadb:13.0.2are pinned by tag and digest.13.0.2is the versionmariadb:latestcurrently resolves to, so existing data directories are not downgraded.ludeeus/action-shellcheckmoves frommasterto2.0.0.common-services.ymland the workflow actions. The project's own image stays out of it. The WP-CLI version and checksum are updated by hand, together.Tests
tests/security/build-pins.batschecks that the Dockerfile has no floating downloads, thatCOPY --fromimages carry a digest, that WP-CLI comes from a release and is verified, that nginx and MariaDB are pinned, and that everyuses:points to a commit. All five fail onmainand pass here.bats tests/security: 23/23; ShellCheck clean.The image builds for
linux/amd64with the default base image (WP-CLI 2.12.0, Composer 2.11.2,intlandxdebugloaded). A fresh stack with that image, the pinned nginx and MariaDB built from.docker/mariadbinstalls WordPress and WooCommerce, and login, wp-admin,/wp-json/,wp-cron.php, checkout and My Account work.