Repository navigation
Conversation
Add an atomic prepared runtime result that carries logger IDs, logger instances, formatters, and effective levels. Apply schema-v1 formatter defaults and overrides, preserve the legacy instantiation API, and cover the JSON-to-runtime path with focused regressions.
Make configuration contract and JSON tests evaluate every operation in Release builds instead of relying on assert side effects. Preserve the legacy instantiate_configuration backend-only contract while keeping strategy-aware formatter and level preparation in prepare_configuration, and cover that compatibility boundary with a regression test.
Include <algorithm> before the TimeShield formatting header reached through the public utils umbrella. TimeShield uses std::fill without including its declaring header, which breaks the Emscripten smoke build on the current toolchain.
Verify that prepared logger and formatter shared ownership survives clearing the published set, while the existing atomic failure and strategy checks remain active in Release.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Full CI will provide the cross-platform exact-head matrix.