Repository navigation
customSearchUrl in people search; unfollow by default on withdraw (2.3.23) - #30
Merged
Merged
Conversation
retrieve_profile_viewers tells the agent to pass an anonymous viewer's searchUrl to search_people as customSearchUrl, but neither search_people nor nv_search_people declared that field, so zod dropped it and the API rejected the call for lacking a term. Both tools now accept customSearchUrl and, like search_posts, require term or customSearchUrl. withdraw_connection_request documented unfollow as defaulting to true but sent nothing, and Core defaults to false; the tool now sends true unless told otherwise, as the CLI does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_peopleandnv_search_peopleacceptcustomSearchUrl.retrieve_profile_viewerstells the agent to pass an anonymous viewer'ssearchUrlthere, but the field was missing from both zod schemas, so it was dropped and the API rejected the call for lacking a term. Likesearch_posts, both now requiretermorcustomSearchUrl, which is the rule Core already enforces (HasTermOrCustomSearchUrl).withdraw_connection_requestdocumentedunfollowas defaulting to true but sent nothing, and Core defaults to false. It now sendstrueunless the caller passesfalse, as the CLI does.Checks: eslint, typecheck. Probed with the tool's own
validate: the viewer URL survives, including inside thevalueenvelope; a filter-only call is rejected;unfollowdefaults to true.