Repository navigation
List flags: JSON only when bracket-wrapped; exit 5 on a bad JSON list (1.2.25) - #11
Merged
Merged
Conversation
…on a bad JSON list 1.2.24 parsed any value starting with [ as JSON, so a literal such as "[24]7.ai" failed; now only a value both starting with [ and ending with ] is JSON. An invalid JSON list exits with the validation code 5 instead of the general 1, and the new callbacks carry return types. Found by a post-release review of 1.2.24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10 from an independent post-release review of 1.2.24 (three low findings).
[– e.g. company[24]7.ai– was parsed as JSON and failed. Now only a value both starting with[and ending with]is read as a JSON array;[24]7.aiand[24]7.ai,Googlesplit as plain comma lists again.[1]) threw a plain Error, so oclif exited 1. It now raises a CLIError withEXIT_CODE.VALIDATION(5), matching the README's exit-code table and the --term/--url guard.Version 1.2.25. Checks: typecheck, eslint, build; probed the built helper (
[24]7.ai→ plain, JSON array → parsed,[1]→ CLIError exit 5) andlinkedin jobs search --term engineer --companies '[1]'exits 5.