Repository navigation
fix: Remove a grid filter from the state when its value is cleared - #21
Merged
jissereitsma merged 1 commit intoNov 16, 2026
Merged
Conversation
Contributor
|
Nice, I didn't catch this yet. Merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bin/magento setup:di:compileandsetup:static-content:deploy -f en_USon Magento Open Source 2.4.9 / PHP 8.5 with this branch installed: both pass.Refs #19. After the bookmark merge, clearing a filter still leaves the old behaviour in place.
Filter::isEmpty()only treatsnullas empty, so a cleared select ('') or an empty multiselect ([]) is stored and applied as a real condition.FilterActionalso doescontinuefor an empty value, so the previously stored filter is never removed and a cleared text filter keeps its old value.Fix
Filter::isEmpty()now also returns true for''and[].'0'and0stay real values.FilterActioncalls the newState::removeFilter()for an empty submitted value, which drops the filter from the session state and clears its entry in the bookmark's applied filters.Why this approach
The empty check stays in
Filter::isEmpty(), so custom filter implementations keep control of what counts as empty, and the action only decides what to do with the answer.Test plan
Test/Unit/Grid/Filter/FilterTest.phpandTest/Unit/Grid/Action/FilterActionTest.php.phpunit Test/Unitagainst a Magento 2.4.9 checkout: 146 tests, all pass. With the threeGrid/changes stashed, 2 errors and 2 failures in the new tests.